Skip to content

Commit

Permalink
MDL-70291 core: Update lib readme, upgrade and xml files
Browse files Browse the repository at this point in the history
  • Loading branch information
Peter Dias committed Jan 18, 2021
1 parent b21db6a commit 2389cca
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 6 deletions.
11 changes: 7 additions & 4 deletions lib/minify/readme_moodle.txt
Expand Up @@ -11,13 +11,16 @@ mv path-converter-1.1.0/src/ /path/to/moodle/lib/minify/matthiasmullie-pathconve

Local changes applied:

MDL-67115: php 74 compliance - implode() params order. Note this has been fixed upstream
by https://github.com/matthiasmullie/minify/pull/300 so, whenever this library is updated
check if the fix is included and remove this note.

MDL-68191: https://github.com/matthiasmullie/minify/issues/317 is a bug that stops
large sections of the CSS from being minimised, and also is a huge performance drain.
We have applied the fix sent upstream because the performance win is so big.
(E.g. one case I measured, with the bug was 40 seconds to minify CSS, with the fix was
a few seconds. This is one of the reasons Behat runs in the browser are so slow.)
Whenever this library is updated check if the fix is included and remove this note.
NOTE: As of 2020/12/08, only the first commit was brought into Moodle


2020-12-07 - Peter Dias
-----------------------
* Removed php74 compliance step as it is now part of the library
* Updated minify to 1.3.63 and pathconverter to 1.1.3
4 changes: 2 additions & 2 deletions lib/thirdpartylibs.xml
Expand Up @@ -60,14 +60,14 @@
<location>minify/matthiasmullie-minify</location>
<name>MatthiasMullie\Minify</name>
<license>MIT</license>
<version>1.3.61</version>
<version>1.3.63</version>
<licenseversion></licenseversion>
</library>
<library>
<location>minify/matthiasmullie-pathconverter</location>
<name>MatthiasMullie\PathConverter</name>
<license>MIT</license>
<version>1.1.2</version>
<version>1.1.3</version>
<licenseversion></licenseversion>
</library>
<library>
Expand Down
1 change: 1 addition & 0 deletions lib/upgrade.txt
Expand Up @@ -15,6 +15,7 @@ information provided here is intended especially for developers.
* Behat timeout constants behat_base::TIMEOUT, EXTENDED_TIMEOUT, and REDUCED_TIMEOUT, which were deprecated in 3.7, have been removed.
* \core_table\local\filter\filterset::JOINTYPE_DEFAULT is being changed from 1 (ANY) to 2 (ALL). Filterset implementations
can override the default filterset join type by overriding \core_table\local\filter\filterset::get_join_type() instead.
* The minify lib has been upgraded to 1.3.63 and pathconvertor to 1.1.3

=== 3.10 ===
* PHPUnit has been upgraded to 8.5. That comes with a few changes:
Expand Down

0 comments on commit 2389cca

Please sign in to comment.