MDL-7861 fixed regression caused by one of previous commit related to…

… print_single_button() and friends - old & handling restored, thanks Eloy for spotting the problem :-)
moodle · Jan 22, 2007 · 2463ef8 · 2463ef8
1 parent 85bb13e
commit 2463ef8
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/lib/weblib.php b/lib/weblib.php
@@ -2901,9 +2901,10 @@ function print_box_end($return=false) {
  */
 function print_single_button($link, $options, $label='OK', $method='get', $target='_self', $return=false) {
     $output = '';
+    $link = str_replace('"', '&quot;', $link); //basic XSS protection
     $output .= '<div class="singlebutton">';
     // taking target out, will need to add later target="'.$target.'"
-    $output .= '<form action="'. s($link) .'" method="'. $method .'">';   
+    $output .= '<form action="'. $link .'" method="'. $method .'">';   
     $output .= '<fieldset class="invisiblefieldset">';
     if ($options) {
         foreach ($options as $name => $value) {