Skip to content

Commit

Permalink
MDL-59395 report_log: removed unnecessary Behat javascript tags
Browse files Browse the repository at this point in the history
Reverts the original fix for the failing Behat tests and solves
it in a better way - it is now faster!

Part of MDL-59290.
  • Loading branch information
mdjnelson committed Jul 6, 2017
1 parent d5d70e5 commit 272094b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 7 deletions.
3 changes: 0 additions & 3 deletions report/log/tests/behat/filter_log.feature
Expand Up @@ -17,7 +17,6 @@ Feature: In a report, admin can filter log data
| student1 | C1 | student |
And I log in as "admin"

@javascript
Scenario: Filter log report for standard and legacy log reader
Given I navigate to "Manage log stores" node in "Site administration > Plugins > Logging"
And I click on "Enable" "link" in the "Legacy log" "table_row"
Expand All @@ -42,7 +41,6 @@ Feature: In a report, admin can filter log data
And I should see "user login"
And I should not see "Nothing to display"

@javascript
Scenario: Filter log report for standard log reader
Given I am on "Course 1" course homepage
And I navigate to course participants
Expand All @@ -57,7 +55,6 @@ Feature: In a report, admin can filter log data
And I press "Get these logs"
Then I should see "User logged in as another user"

@javascript
Scenario: Filter log report for legacy log reader
Given I navigate to "Manage log stores" node in "Site administration > Plugins > Logging"
And I click on "Enable" "link" in the "Legacy log" "table_row"
Expand Down
6 changes: 2 additions & 4 deletions report/log/tests/behat/user_log.feature
Expand Up @@ -33,19 +33,17 @@ Feature: User can view activity log.
And I press "Save changes"
And I log out

@javascript
Scenario: View Todays' and all log report for user
Given I log in as "teacher1"
And I am on "Course 1" course homepage
And I navigate to course participants
And I click on "img.userpicture" "css_element" in the "Student 1" "table_row"
And I follow "Student 1"
When I follow "Today's logs"
And I should see "Assignment: Test assignment name"
And I follow "Student 1"
And I follow "All logs"
Then I should see "Assignment: Test assignment name"

@javascript
Scenario: No log reader enabled should be visible when no log store enabled.
Given I log in as "admin"
And I navigate to "Manage log stores" node in "Site administration > Plugins > Logging"
Expand All @@ -54,7 +52,7 @@ Feature: User can view activity log.
And I log in as "teacher1"
And I am on "Course 1" course homepage
And I navigate to course participants
And I click on "img.userpicture" "css_element" in the "Student 1" "table_row"
And I follow "Student 1"
When I follow "Today's logs"
And I should see "No log reader enabled"
And I follow "Student 1"
Expand Down

0 comments on commit 272094b

Please sign in to comment.