MDL-74211 behat: convert few more steps to use new data generators

question/bank/managecategories/tests/behat/move_question_categories.feature

@@ -22,7 +22,8 @@ Feature: A teacher can move question categories in the question bank
 
   Scenario: A question category can be moved to another context
     When I follow "Test quiz"
-    And I am on the "Course 1" "core_question > course question categories" page
+    And I navigate to "Question bank" in current page administration
+    And I select "Categories" from the "Question bank tertiary navigation" singleselect
     And I follow "Add category"
     And I set the following fields to these values:
       | Name            | Test category         |
@@ -33,7 +34,8 @@ Feature: A teacher can move question categories in the question bank
 
   Scenario: A question category can be moved to top level
     When I follow "Test quiz"
-    And I am on the "Course 1" "core_question > course question categories" page
+    And I navigate to "Question bank" in current page administration
+    And I select "Categories" from the "Question bank tertiary navigation" singleselect
     And I follow "Add category"
     And I set the following fields to these values:
       | Name            | Test category         |

question/bank/managecategories/tests/behat/question_categories.feature

@@ -70,7 +70,7 @@ Feature: A teacher can put questions in categories in the question bank
 
   @_file_upload
   Scenario: Multi answer questions with their child questions can be moved to another category when the current category is deleted
-    When I am on the "Course 1" "core_question > course question categories" page
+    When I am on the "Course 1" "core_question > course question import" page
     And I set the field "id_format_xml" to "1"
     And I upload "question/format/xml/tests/fixtures/multianswer.xml" file to "Import" filemanager
     And I press "id_submitbutton"

question/format/aiken/tests/behat/aiken_export.feature

@@ -21,12 +21,9 @@ Feature: Test exporting questions using Aiken format.
       | questioncategory | qtype        | name             | template    |
       | Test questions   | multichoice  | Multi-choice-001 | two_of_four |
       | Test questions   | multichoice  | Multi-choice-002 | one_of_four |
-    And I log in as "teacher1"
-    And I am on "Course 1" course homepage
 
   Scenario: Aiken export
-    When I navigate to "Question bank" in current page administration
-    And I select "Export" from the "Question bank tertiary navigation" singleselect
+    When I am on the "Course 1" "core_question > course question export" page logged in as "teacher1"
     And I set the field "id_format_aiken" to "1"
     When I press "Export questions to file"
     Then following "click here" should download between "68" and "70" bytes

question/format/aiken/tests/behat/aiken_import.feature

@@ -14,16 +14,13 @@ Feature: Test importing questions from Aiken format.
     And the following "course enrolments" exist:
       | user    | course | role           |
       | teacher | C1     | editingteacher |
-    And I log in as "teacher"
-    And I am on "Course 1" course homepage
 
   @javascript @_file_upload
   Scenario: import some Aiken questions
-    When I navigate to "Question bank" in current page administration
-    And I select "Import" from the "Question bank tertiary navigation" singleselect
+    Given I am on the "Course 1" "core_question > course question import" page logged in as "teacher"
     And I set the field "id_format_aiken" to "1"
     And I upload "question/format/aiken/tests/fixtures/questions.aiken.txt" file to "Import" filemanager
-    And I press "id_submitbutton"
+    When I press "id_submitbutton"
     Then I should see "Parsing questions from import file."
     And I should see "Importing 2 questions from file"
     And I should see "The Moodle project was started by:"

question/format/gift/tests/behat/import_export.feature

@@ -14,14 +14,11 @@ Feature: Test importing questions from GIFT format.
     And the following "course enrolments" exist:
       | user    | course | role           |
       | teacher | C1     | editingteacher |
-    And I log in as "teacher"
-    And I am on "Course 1" course homepage
+    And I am on the "Course 1" "core_question > course question import" page logged in as "teacher"
 
   @javascript @_file_upload
   Scenario: import some GIFT questions
-    When I navigate to "Question bank" in current page administration
-    And I select "Import" from the "Question bank tertiary navigation" singleselect
-    And I set the field "id_format_gift" to "1"
+    When I set the field "id_format_gift" to "1"
     And I upload "question/format/gift/tests/fixtures/questions.gift.txt" file to "Import" filemanager
     And I press "id_submitbutton"
     Then I should see "Parsing questions from import file."
@@ -40,9 +37,7 @@ Feature: Test importing questions from GIFT format.
 
   @javascript @_file_upload
   Scenario: import a GIFT file which specifies the category
-    When I navigate to "Question bank" in current page administration
-    And I select "Import" from the "Question bank tertiary navigation" singleselect
-    And I set the field "id_format_gift" to "1"
+    When I set the field "id_format_gift" to "1"
     And I upload "question/format/gift/tests/fixtures/questions_in_category.gift.txt" file to "Import" filemanager
     And I press "id_submitbutton"
     Then I should see "Parsing questions from import file."
@@ -53,9 +48,7 @@ Feature: Test importing questions from GIFT format.
 
   @javascript @_file_upload
   Scenario: import some GIFT questions with unsupported encoding
-    When I navigate to "Question bank" in current page administration
-    And I select "Import" from the "Question bank tertiary navigation" singleselect
-    And I set the field "id_format_gift" to "1"
+    When I set the field "id_format_gift" to "1"
     And I upload "question/format/gift/tests/fixtures/questions_encoding_windows-1252.gift.txt" file to "Import" filemanager
     And I press "id_submitbutton"
     Then I should see "The file you selected does not use UTF-8 character encoding. GIFT format files must use UTF-8."

question/format/xml/tests/behat/import_export.feature

@@ -14,13 +14,10 @@ Feature: Test importing questions from Moodle XML format.
     And the following "course enrolments" exist:
       | user    | course | role           |
       | teacher | C1     | editingteacher |
-    And I log in as "teacher"
-    And I am on "Course 1" course homepage
 
   @javascript @_file_upload
   Scenario: import some true/false questions from Moodle XML format
-    When I navigate to "Question bank" in current page administration
-    And I select "Import" from the "Question bank tertiary navigation" singleselect
+    When I am on the "Course 1" "core_question > course question import" page logged in as "teacher"
     And I set the field "id_format_xml" to "1"
     And I upload "question/format/xml/tests/fixtures/truefalse.xml" file to "Import" filemanager
     And I press "id_submitbutton"
@@ -33,18 +30,15 @@ Feature: Test importing questions from Moodle XML format.
     Then I should see "Moodle acronym (True)"
 
     # Now export again.
-    And I am on "Course 1" course homepage
-    When I navigate to "Question bank" in current page administration
-    And I select "Export" from the "Question bank tertiary navigation" singleselect
+    When I am on the "Course 1" "core_question > course question export" page logged in as "teacher"
     And I set the field "id_format_xml" to "1"
     And I set the field "Export category" to "TrueFalse"
     And I press "Export questions to file"
-    And following "click here" should download between "57100" and "58150" bytes
+    Then following "click here" should download between "57100" and "58150" bytes
 
   @javascript @_file_upload
   Scenario: import some multiple choice questions from Moodle XML format
-    When I navigate to "Question bank" in current page administration
-    And I select "Import" from the "Question bank tertiary navigation" singleselect
+    When I am on the "Course 1" "core_question > course question import" page logged in as "teacher"
     And I set the field "id_format_xml" to "1"
     And I upload "question/format/xml/tests/fixtures/multichoice.xml" file to "Import" filemanager
     And I press "id_submitbutton"
@@ -56,8 +50,7 @@ Feature: Test importing questions from Moodle XML format.
 
   @javascript @_file_upload
   Scenario: import some multi-answer questions from Moodle XML format
-    When I navigate to "Question bank" in current page administration
-    And I select "Import" from the "Question bank tertiary navigation" singleselect
+    When I am on the "Course 1" "core_question > course question import" page logged in as "teacher"
     And I set the field "id_format_xml" to "1"
     And I upload "question/format/xml/tests/fixtures/multianswer.xml" file to "Import" filemanager
     And I press "id_submitbutton"
@@ -69,8 +62,7 @@ Feature: Test importing questions from Moodle XML format.
 
   @javascript @_file_upload
   Scenario: import some questions with legacy-style images from Moodle XML format
-    When I navigate to "Question bank" in current page administration
-    And I select "Import" from the "Question bank tertiary navigation" singleselect
+    When I am on the "Course 1" "core_question > course question import" page logged in as "teacher"
     And I set the field "id_format_xml" to "1"
     And I upload "question/format/xml/tests/fixtures/sample_questions_with_old_image_tag.xml" file to "Import" filemanager
     And I press "id_submitbutton"

question/tests/behat/delete_questions.feature

@@ -20,9 +20,7 @@ Feature: A teacher can delete questions in the question bank
     And the following "questions" exist:
       | questioncategory | qtype | name                        | questiontext                  |
       | Test questions   | essay | Test question to be deleted | Write about whatever you want |
-    And I log in as "teacher1"
-    And I am on "Course 1" course homepage
-    And I navigate to "Question bank" in current page administration
+    And I am on the "Course 1" "core_question > course question bank" page logged in as "teacher1"
 
   @javascript
   Scenario: A question not used anywhere can really be deleted
@@ -52,8 +50,7 @@ Feature: A teacher can delete questions in the question bank
     And quiz "Test quiz" contains the following questions:
       | question                         | page | requireprevious |
       | Test used question to be deleted | 1    | 0               |
-    When I am on "Course 1" course homepage
-    And I navigate to "Question bank" in current page administration
+    When I am on the "Course 1" "core_question > course question bank" page
     And I choose "Delete" action for "Test used question to be deleted" in the question bank
     And I press "Delete"
     Then I should not see "Test used question to be deleted"

question/tests/behat/duplicate_questions.feature

@@ -20,9 +20,7 @@ Feature: A teacher can duplicate questions in the question bank
     And the following "questions" exist:
       | questioncategory | qtype | name                       | questiontext                  | idnumber |
       | Test questions   | essay | Test question to be copied | Write about whatever you want | qid      |
-    And I log in as "teacher"
-    And I am on "Course 1" course homepage
-    And I navigate to "Question bank" in current page administration
+    And I am on the "Course 1" "core_question > course question bank" page logged in as "teacher"
 
   Scenario: Duplicating a previously created question
     When I choose "Duplicate" action for "Test question to be copied" in the question bank

question/tests/behat/edit_question_tags.feature

@@ -20,9 +20,7 @@ Feature: A teacher can manage tags on questions in the question bank
     And the following "questions" exist:
       | questioncategory | qtype | name                       | questiontext                  |
       | Test questions   | essay | Test question to be tagged | Write about whatever you want |
-    And I log in as "teacher1"
-    And I am on "Course 1" course homepage
-    And I navigate to "Question bank" in current page administration
+    And I am on the "Course 1" "core_question > course question bank" page logged in as "teacher1"
 
   @javascript
   Scenario: Manage tags on a question

question/tests/behat/edit_questions.feature

@@ -20,6 +20,7 @@ Feature: A teacher can edit questions in the question bank
     And the following "questions" exist:
       | questioncategory | qtype | name                       | questiontext                  |
       | Test questions   | essay | Test question to be edited | Write about whatever you want |
+    And I am on the "Course 1" "core_question > course question bank" page logged in as "teacher1"
 
   Scenario: Edit a previously created question
     When I am on the "Test question to be edited" "core_question > edit" page logged in as "teacher1"

question/tests/behat/edit_questions_standard_tags.feature

@@ -20,9 +20,7 @@ Feature: The questions can be tagged
       | bar  | 1          |
 
   Scenario: The tags autocomplete should include standard tags
-    When I log in as "teacher1"
-    And I am on "Course 1" course homepage
-    And I navigate to "Question bank" in current page administration
+    When I am on the "Course 1" "core_question > course question bank" page logged in as "teacher1"
     And I press "Create a new question ..."
     And I set the field "item_qtype_truefalse" to "1"
     And I click on "Add" "button" in the "Choose a question type to add" "dialogue"

question/tests/behat/filter_questions_by_tag.feature

@@ -21,14 +21,11 @@ Feature: The questions in the question bank can be filtered by tags
       | questioncategory | qtype     | name            | user     | questiontext    |
       | Test questions   | essay     | question 1 name | admin    | Question 1 text |
       | Test questions   | essay     | question 2 name | teacher1 | Question 2 text |
-    And I log in as "teacher1"
-    And I am on "Course 1" course homepage
-    And I navigate to "Question bank" in current page administration
-    And I choose "Edit question" action for "question 1 name" in the question bank
+    And I am on the "question 1 name" "core_question > edit" page logged in as "teacher1"
     And I set the following fields to these values:
       | Tags | foo |
     And I press "id_submitbutton"
-    And I choose "Edit question" action for "question 2 name" in the question bank
+    And I am on the "question 2 name" "core_question > edit" page
     And I set the following fields to these values:
       | Tags | bar |
     And I press "id_submitbutton"

question/tests/behat/question_categories.feature

@@ -28,7 +28,7 @@ Feature: A teacher can move questions between categories in the question bank
 
   @javascript
   Scenario: Move a question between categories via the question page
-    When I navigate to "Question bank" in current page administration
+    When I am on the "Course 1" "core_question > course question bank" page logged in as "teacher1"
     And I set the field "Select a category" to "Used category"
     And I click on "Test question to be moved" "checkbox" in the "Test question to be moved" "table_row"
     And I click on "With selected" "button"

question/tests/behat/question_categories_idnumber.feature

@@ -26,8 +26,7 @@ Feature: A teacher can put questions with idnumbers in categories in the questio
       | questioncategory | qtype | name            | questiontext                  | idnumber |
       | Used category    | essay | Test question 1 | Write about whatever you want | q1       |
       | Used category    | essay | Test question 2 | Write about whatever you want | q2       |
-    And I navigate to "Question bank" in current page administration
-    And I choose "Edit question" action for "Test question 2" in the question bank
+    And I am on the "Test question 2" "core_question > edit" page
     And I set the field "ID number" to "q1"
     And I press "submitbutton"
     # This is the standard form warning reminding the user that the idnumber needs to be unique for a category.
@@ -41,8 +40,7 @@ Feature: A teacher can put questions with idnumbers in categories in the questio
     And the following "questions" exist:
       | questioncategory | qtype | name            | questiontext                  | idnumber |
       | Used category    | essay | Test question 1 | Write about whatever you want | q1       |
-    And I navigate to "Question bank" in current page administration
-    And I choose "Edit question" action for "Test question 1" in the question bank
+    And I am on the "Test question 1" "core_question > edit" page
     And I press "Save changes"
     Then I should not see "This ID number is already in use"
 
@@ -56,8 +54,7 @@ Feature: A teacher can put questions with idnumbers in categories in the questio
       | questioncategory | qtype | name             | questiontext                  | idnumber |
       | Category 1       | essay | Question to edit | Write about whatever you want | q1       |
       | Category 1       | essay | Other question   | Write about whatever you want | q2       |
-    And I navigate to "Question bank" in current page administration
-    And I choose "Edit question" action for "Question to edit" in the question bank
+    And I am on the "Question to edit" "core_question > edit" page
     And I set the field "ID number" to "q2"
     And I press "Save changes"
     Then I should see "This ID number is already in use"
@@ -74,8 +71,7 @@ Feature: A teacher can put questions with idnumbers in categories in the questio
       | Used category    | essay | Test question 1 | Write about whatever you want | q1       |
       | Used category    | essay | Test question 2 | Write about whatever you want | q2       |
       | Subcategory      | essay | Test question 3 | Write about whatever you want | q3       |
-    When I navigate to "Question bank" in current page administration
-    And I choose "Edit question" action for "Test question 3" in the question bank
+    When I am on the "Test question 3" "core_question > edit" page
     # The q1 idnumber is allowed for this question while it is in the Subcategory.
     And I set the field "ID number" to "q1"
     And I press "submitbutton"

question/tests/behat/select_questions.feature

@@ -22,9 +22,7 @@ Feature: The questions in the question bank can be selected in various ways
       | Test questions   | essay     | A question 1 name | admin    | Question 1 text |
       | Test questions   | essay     | B question 2 name | teacher1 | Question 2 text |
       | Test questions   | numerical | C question 3 name | teacher1 | Question 3 text |
-    And I log in as "teacher1"
-    And I am on "Course 1" course homepage
-    And I navigate to "Question bank" in current page administration
+    And I am on the "Course 1" "core_question > course question bank" page logged in as "teacher1"
 
   @javascript
   Scenario: The question text can be chosen all in the list of questions

question/tests/behat/sort_questions.feature

@@ -22,9 +22,7 @@ Feature: The questions in the question bank can be sorted in various ways
       | Test questions   | essay     | A question 1 name | admin    | Question 1 text | numidnum</a |
       | Test questions   | essay     | B question 2 name | teacher1 | Question 2 text |             |
       | Test questions   | numerical | C question 3 name | teacher1 | Question 3 text | numidnum</c |
-    And I log in as "teacher1"
-    And I am on "Course 1" course homepage
-    And I navigate to "Question bank" in current page administration
+    And I am on the "Course 1" "core_question > course question bank" page logged in as "teacher1"
 
   @javascript
   Scenario: The questions are sorted by type by default