MDL-74802 core: Remove tooltip on the notification close button

Reverting the addition of a Boostrap tooltip on the alert notification's close button. It introduced a bug where the tooltip remains after dismissing the notification alert. We can manually toggle the state of the tooltip via JS, but I don't think it's worth the effort. The tooltip is meant as an added bonus for sighted users to see what the close button is about.
moodle · Jun 10, 2022 · 2c58871 · 2c58871
1 parent 42d214d
commit 2c58871
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 8 deletions.
diff --git a/lib/templates/notification_error.mustache b/lib/templates/notification_error.mustache
@@ -41,8 +41,7 @@
     }}>
     {{{ message }}}
     {{# closebutton }}{{!
-    }}<button type="button" class="close" data-dismiss="alert"{{!
-            }} title="{{#str}}dismissnotification, core{{/str}}" data-toggle="tooltip">
+    }}<button type="button" class="close" data-dismiss="alert">
         <span aria-hidden="true">&times;</span>
         <span class="sr-only">{{#str}}dismissnotification, core{{/str}}</span>
     </button>{{!

diff --git a/lib/templates/notification_info.mustache b/lib/templates/notification_info.mustache
@@ -41,8 +41,7 @@
     }}>
     {{{ message }}}
     {{# closebutton }}{{!
-    }}<button type="button" class="close" data-dismiss="alert"{{!
-            }} title="{{#str}}dismissnotification, core{{/str}}" data-toggle="tooltip">
+    }}<button type="button" class="close" data-dismiss="alert">
         <span aria-hidden="true">&times;</span>
         <span class="sr-only">{{#str}}dismissnotification, core{{/str}}</span>
     </button>{{!

diff --git a/lib/templates/notification_success.mustache b/lib/templates/notification_success.mustache
@@ -41,8 +41,7 @@
     }}>
     {{{ message }}}
     {{# closebutton }}{{!
-    }}<button type="button" class="close" data-dismiss="alert"{{!
-            }} title="{{#str}}dismissnotification, core{{/str}}" data-toggle="tooltip">
+    }}<button type="button" class="close" data-dismiss="alert">
         <span aria-hidden="true">&times;</span>
         <span class="sr-only">{{#str}}dismissnotification, core{{/str}}</span>
     </button>{{!

diff --git a/lib/templates/notification_warning.mustache b/lib/templates/notification_warning.mustache
@@ -41,8 +41,7 @@
     }}>
     {{{ message }}}
     {{# closebutton }}{{!
-    }}<button type="button" class="close" data-dismiss="alert"{{!
-            }} title="{{#str}}dismissnotification, core{{/str}}" data-toggle="tooltip">
+    }}<button type="button" class="close" data-dismiss="alert">
         <span aria-hidden="true">&times;</span>
         <span class="sr-only">{{#str}}dismissnotification, core{{/str}}</span>
     </button>{{!