Skip to content

Commit

Permalink
MDL-70083 message: Adapt tests to new number of default providers
Browse files Browse the repository at this point in the history
We now have enough default providers, so no need to show a warning in that case
  • Loading branch information
jleyva committed Nov 5, 2021
1 parent 6f0f979 commit 2d5ee7b
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions message/output/airnotifier/tests/manager_test.php
Expand Up @@ -42,7 +42,7 @@ public function test_check_configuration_default() {
$this->assertEquals(core\check\result::ERROR, $checks[3]->get_status()); // Airnotifier NOT configured, missing key.
$this->assertEquals(core\check\result::OK, $checks[4]->get_status()); // Airnotifier URL available.
$this->assertEquals(core\check\result::ERROR, $checks[5]->get_status()); // Missing access key.
$this->assertEquals(core\check\result::WARNING, $checks[6]->get_status()); // Only a few of default mobile notifications.
$this->assertEquals(core\check\result::OK, $checks[6]->get_status()); // Enough default mobile notifications.
$this->assertEquals(core\check\result::ERROR, $checks[7]->get_status()); // No registered devices yet.
}

Expand All @@ -66,7 +66,7 @@ public function test_check_configuration_with_token() {
$this->assertEquals(core\check\result::OK, $checks[3]->get_status()); // Airnotifier configured.
$this->assertEquals(core\check\result::OK, $checks[4]->get_status()); // Airnotifier URL available.
// The original function fourth check (access key valid in the remote Airnotifier server) is not mockable.
$this->assertEquals(core\check\result::WARNING, $checks[5]->get_status()); // Only a few of default mobile notifications.
$this->assertEquals(core\check\result::OK, $checks[5]->get_status()); // Enough default mobile notifications.
$this->assertEquals(core\check\result::ERROR, $checks[6]->get_status()); // No registered devices yet.
}

Expand Down Expand Up @@ -94,7 +94,7 @@ public function test_check_configuration_incorrect_settings() {
$this->assertEquals(core\check\result::ERROR, $checks[4]->get_status()); // Airnotifier URL available.
$this->assertEquals(core\check\result::OK, $checks[5]->get_status()); // Invalid setting (empty space).
// The original function fifth check (access key valid in the remote Airnotifier server) is not mockable.
$this->assertEquals(core\check\result::WARNING, $checks[6]->get_status()); // Only a few of default mobile notifications.
$this->assertEquals(core\check\result::OK, $checks[6]->get_status()); // Enough default mobile notifications.
$this->assertEquals(core\check\result::ERROR, $checks[7]->get_status()); // No registered devices yet.
}

Expand Down

0 comments on commit 2d5ee7b

Please sign in to comment.