Merge branch 'wip_MDL-60250_master' of git://github.com/gjb2048/moodle

moodle · Oct 25, 2017 · 3b4e9a9 · 3b4e9a9
2 parents 507335e + 6d5f9d1
commit 3b4e9a9
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 0 deletions.
diff --git a/theme/bootstrapbase/less/bootstrap/popovers.less b/theme/bootstrapbase/less/bootstrap/popovers.less
@@ -6,6 +6,7 @@
 .popover {
   position: absolute;
   top: 0;
+  /*rtl:ignore*/
   left: 0;
   z-index: @zindexPopover;
   display: none;

diff --git a/theme/bootstrapbase/readme_moodle.txt b/theme/bootstrapbase/readme_moodle.txt
@@ -51,3 +51,10 @@ in the compiled CSS (MDL-53152):
 * @gridRowWidth
 * @gridRowWidth1200
 * @gridRowWidth768
+
+popovers.less
+-------------
+MDL-60250 - The '/*rtl:ignore*/' directive has been added to the 'left' attribute of the 'popover' class so that
+the rtlcss-php tool (https://github.com/moodlehq/rtlcss-php) does not flip this to a 'right' attribute and cause
+the popover to be misplaced on the page when the JavaScript calculates the postion of the popover and adds an
+overriding inline CSS 'left' attribute which is fine in LTR languages but confuses it in RTL languages.
diff --git a/theme/bootstrapbase/style/moodle.css b/theme/bootstrapbase/style/moodle.css
@@ -14968,6 +14968,7 @@ input[type="submit"].btn.btn-mini {
 .popover {
   position: absolute;
   top: 0;
+  /*rtl:ignore*/
   left: 0;
   z-index: 1010;
   display: none;