MDL-72029 Lesson: Prevent arbitrary file read when importing lesson q…

…uestions in blackboard format
moodle · Jul 6, 2022 · 3cafb30 · 3cafb30
1 parent d585f90
commit 3cafb30
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/question/format/blackboard_six/format.php b/question/format/blackboard_six/format.php
@@ -152,7 +152,8 @@ public function readdata($filename) {
                     }
                     if ($examfile->getAttribute('type') == 'assessment/x-bb-pool') {
                         if ($examfile->getAttribute('baseurl')) {
-                            $fileobj->filebase = $this->tempdir. '/' . $examfile->getAttribute('baseurl');
+                            $fileobj->filebase = clean_param($this->tempdir . '/'
+                                . $examfile->getAttribute('baseurl'), PARAM_SAFEPATH);
                         }
                         if ($content = $this->get_filecontent($examfile->getAttribute('file'))) {
                             $fileobj->filetype = self::FILETYPE_POOL;