Applying the field_exists() check to add and drop fields.

moodle · Sep 30, 2006 · 3e1861c · 3e1861c
1 parent 55b4d09
commit 3e1861c
Showing 1 changed file with 12 additions and 0 deletions.
diff --git a/lib/ddllib.php b/lib/ddllib.php
@@ -595,6 +595,12 @@ function add_field($table, $field, $continue=true, $feedback=true) {
         return false;
     }
 
+/// Check the field doesn't exist
+    if (field_exists($table, $field)) {
+        debugging('Field ' . $field->getName() . ' exists. Skipping its creation', DEBUG_DEVELOPER);
+        return true;
+    }
+
     if(!$sqlarr = $table->getAddFieldSQL($CFG->dbtype, $CFG->prefix, $field, false)) {
         return true; //Empty array = nothing to do = no error
     }
@@ -625,6 +631,12 @@ function drop_field($table, $field, $continue=true, $feedback=true) {
         return false;
     }
 
+/// Check the field exists
+    if (!field_exists($table, $field)) {
+        debugging('Field ' . $field->getName() . ' do not exist. Skipping its deletion', DEBUG_DEVELOPER);
+        return true;
+    }
+
     if(!$sqlarr = $table->getDropFieldSQL($CFG->dbtype, $CFG->prefix, $field, false)) {
         return true; //Empty array = nothing to do = no error
     }