Merge branch 'MDL-50272' of https://github.com/paulholden/moodle

repository/lib.php

@@ -1789,9 +1789,12 @@ public function import_external_file_contents(stored_file $file, $maxbytes = 0)
      *
      * @param string $source encoded and serialized data of file
      * @return int file size in bytes
+     *
+     * @deprecated since Moodle 4.3
      */
     public function get_file_size($source) {
-        // TODO MDL-33297 remove this function completely?
+        debugging(__FUNCTION__ . ' is deprecated, please do not use it any more', DEBUG_DEVELOPER);
+
         $browser    = get_file_browser();
         $params     = unserialize(base64_decode($source));
         $contextid  = clean_param($params['contextid'], PARAM_INT);

repository/upgrade.txt

@@ -3,6 +3,9 @@ information provided here is intended especially for developers. Full
 details of the repository API are available on Moodle docs:
 http://docs.moodle.org/dev/Repository_API
 
+=== 4.3 ===
+* The base `repository` class method `get_file_size` has been deprecated and should not be used any more
+
 === 4.0 ===
 * The repository_boxnet has been completely removed.
 * The repository_picasa has been completely removed (Picasa is discontinued since 2016).