MDL-51919 forms lib: Autocomplete doesn't hide prematurely.

Quickly navigating via the keyboard to an autocomplete element and hitting down would result in the selections being displayed and then quickly removed. This has now been fixed.
moodle · Oct 28, 2015 · 527bde6 · 527bde6
1 parent e360ff5
commit 527bde6
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/lib/amd/build/form-autocomplete.min.js b/lib/amd/build/form-autocomplete.min.js
diff --git a/lib/amd/src/form-autocomplete.js b/lib/amd/src/form-autocomplete.js
@@ -585,10 +585,12 @@ define(['jquery', 'core/log', 'core/str', 'core/templates', 'core/notification']
                 window.clearTimeout(closeSuggestionsTimer);
             }
             closeSuggestionsTimer = window.setTimeout(function() {
-                if ((e.type == 'blur') && tags) {
-                    createItem(inputId, suggestionsId, selectionId, multiple, originalSelect);
+                if (e.type == 'blur') {
+                    if (tags) {
+                        createItem(inputId, suggestionsId, selectionId, multiple, originalSelect);
+                    }
+                    closeSuggestions(inputId, suggestionsId, selectionId);
                 }
-                closeSuggestions(inputId, suggestionsId, selectionId);
             }, 500);
         });
         var arrowElement = $(document.getElementById(downArrowId));