mirrored from git://git.moodle.org/moodle.git
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
MDL-69232 behat: Make selenium start more fault tolerant
The session was previously only started once, but has now been moved to restart between each test. Because of this the `$session->start()` is now called more frequently which exposes a pre-existing issue whereby Selenium will periodically fail to start. When the session was only started at the beginning of the test, and at occasional other times, it made sense to always stop the test runner because it signified an issue with obtaining the session at all. Since the session is restarted more frequently, and now between every test, it no longer makes sense to do this. The test should only be _stopped_ if the first attempt to obtain the Session fails. Once a Session has been retrieved at least once it no longer makes sense to assume that the failure was a configuration failure, but a connection failure. Therefore subsequent tests should be attempted.
- Loading branch information
1 parent
5e99058
commit 5306f2f
Showing
1 changed file
with
43 additions
and
29 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters