Skip to content

Commit

Permalink
MDL-46844 Embed LTI External Tools with an IFrame
Browse files Browse the repository at this point in the history
Clears up weird browser issues that occur when embedding content with an
`<object>` tag.
  • Loading branch information
Andrew Schmadel committed Sep 10, 2014
1 parent fd72531 commit 53f9354
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions mod/lti/view.php
Expand Up @@ -121,10 +121,10 @@
echo "</script>\n";
echo "<p>".get_string("basiclti_in_new_window", "lti")."</p>\n";
} else {
// Request the launch content with an object tag
echo '<object id="contentframe" height="600px" width="100%" type="text/html" data="launch.php?id='.$cm->id.'"></object>';
// Request the launch content with an iframe tag.
echo '<iframe id="contentframe" height="600px" width="100%" src="launch.php?id='.$cm->id.'"></iframe>';

//Output script to make the object tag be as large as possible
// Output script to make the iframe be as large as possible.
$resize = '
<script type="text/javascript">
//<![CDATA[
Expand Down

0 comments on commit 53f9354

Please sign in to comment.