Skip to content

Commit

Permalink
MDL-76657 gradebook: Remove hard-coded plugin names from unit test
Browse files Browse the repository at this point in the history
  • Loading branch information
@rezaies
rezaies committed Jan 3, 2023
1 parent fcfc240 commit 540ce30
Showing 1 changed file with 115 additions and 95 deletions.
210 changes: 115 additions & 95 deletions grade/tests/output/general_action_bar_test.php
View file
Expand Up @@ -62,26 +62,25 @@ public function test_export_for_template(string $userrole, bool $enableoutcomes,
// test is being run, therefore, we need to know which links can be
// present in a standard Moodle install, and only check them.
$allcorenavlinks = [
'View' => [
'Grader report',
'Grade history',
'Grade summary',
'Outcomes report',
'Overview report',
'Single view',
'User report',
get_string('view') => [
get_string('pluginname', 'gradereport_grader'),
get_string('pluginname', 'gradereport_history'),
get_string('pluginname', 'gradereport_outcomes'),
get_string('pluginname', 'gradereport_overview'),
get_string('pluginname', 'gradereport_singleview'),
get_string('pluginname', 'gradereport_user'),
],
'Setup' => [
'Gradebook setup',
'Course grade settings',
'Preferences: Grader report',
get_string('setup', 'grades') => [
get_string('gradebooksetup', 'grades'),
get_string('coursegradesettings', 'grades'),
get_string('preferences', 'grades') . ': ' . get_string('pluginname', 'gradereport_grader'),
],
'More' => [
'Scales',
'Outcomes',
'Grade letters',
'Import',
'Export',
get_string('moremenu') => [
get_string('scales'),
get_string('outcomes', 'grades'),
get_string('gradeletters', 'grades'),
get_string('import', 'grades'),
get_string('export', 'grades'),
],
];

Expand Down Expand Up @@ -148,133 +147,154 @@ public function test_export_for_template(string $userrole, bool $enableoutcomes,
* @return array
*/
public function export_for_template_provider(): array {
$graderpluginname = get_string('pluginname', 'gradereport_grader');
$historypluginname = get_string('pluginname', 'gradereport_history');
$outcomespluginname = get_string('pluginname', 'gradereport_outcomes');
$overviewpluginname = get_string('pluginname', 'gradereport_overview');
$singleviewpluginname = get_string('pluginname', 'gradereport_singleview');
$userpluginname = get_string('pluginname', 'gradereport_user');

$viewstr = get_string('view');
$setupstr = get_string('setup', 'grades');
$morestr = get_string('moremenu');

$gradebooksetupstr = get_string('gradebooksetup', 'grades');
$coursegradesettingsstr = get_string('coursegradesettings', 'grades');
$graderpreferencesstr = get_string('preferences', 'grades') . ': ' . get_string('pluginname', 'gradereport_grader');

$scalesstr = get_string('scales');
$outcomesstr = get_string('outcomes', 'grades');
$gradelettersstr = get_string('gradeletters', 'grades');
$importstr = get_string('import', 'grades');
$exportstr = get_string('export', 'grades');

return [
'Gradebook general navigation for admin; outcomes disabled.' => [
'admin',
false,
[
'View' => [
'Grader report',
'Grade history',
'Overview report',
'Single view',
'User report',
$viewstr => [
$graderpluginname,
$historypluginname,
$overviewpluginname,
$singleviewpluginname,
$userpluginname,
],
'Setup' => [
'Gradebook setup',
'Course grade settings',
'Preferences: Grader report',
$setupstr => [
$gradebooksetupstr,
$coursegradesettingsstr,
$graderpreferencesstr,
],
'More' => [
'Scales',
'Grade letters',
'Import',
'Export',
$morestr => [
$scalesstr,
$gradelettersstr,
$importstr,
$exportstr,
],
],
],
'Gradebook general navigation for admin; outcomes enabled.' => [
'admin',
true,
[
'View' => [
'Grader report',
'Grade history',
'Outcomes report',
'Overview report',
'Single view',
'User report',
$viewstr => [
$graderpluginname,
$historypluginname,
$outcomespluginname,
$overviewpluginname,
$singleviewpluginname,
$userpluginname,
],
'Setup' => [
'Gradebook setup',
'Course grade settings',
'Preferences: Grader report',
$setupstr => [
$gradebooksetupstr,
$coursegradesettingsstr,
$graderpreferencesstr,
],
'More' => [
'Scales',
'Outcomes',
'Grade letters',
'Import',
'Export',
$morestr => [
$scalesstr,
$outcomesstr,
$gradelettersstr,
$importstr,
$exportstr,
],
],
],
'Gradebook general navigation for editing teacher; outcomes disabled.' => [
'editingteacher',
false,
[
'View' => [
'Grader report',
'Grade history',
'Overview report',
'Single view',
'User report',
$viewstr => [
$graderpluginname,
$historypluginname,
$overviewpluginname,
$singleviewpluginname,
$userpluginname,
],
'Setup' => [
'Gradebook setup',
'Course grade settings',
'Preferences: Grader report',
$setupstr => [
$gradebooksetupstr,
$coursegradesettingsstr,
$graderpreferencesstr,
],
'More' => [
'Scales',
'Grade letters',
'Import',
'Export',
$morestr => [
$scalesstr,
$gradelettersstr,
$importstr,
$exportstr,
],
],
],
'Gradebook general navigation for editing teacher; outcomes enabled.' => [
'editingteacher',
true,
[
'View' => [
'Grader report',
'Grade history',
'Outcomes report',
'Overview report',
'Single view',
'User report',
$viewstr => [
$graderpluginname,
$historypluginname,
$outcomespluginname,
$overviewpluginname,
$singleviewpluginname,
$userpluginname,
],
'Setup' => [
'Gradebook setup',
'Course grade settings',
'Preferences: Grader report',
$setupstr => [
$gradebooksetupstr,
$coursegradesettingsstr,
$graderpreferencesstr,
],
'More' => [
'Scales',
'Outcomes',
'Grade letters',
'Import',
'Export',
$morestr => [
$scalesstr,
$outcomesstr,
$gradelettersstr,
$importstr,
$exportstr,
],
],
],
'Gradebook general navigation for non-editing teacher; outcomes enabled.' => [
'teacher',
true,
[
'View' => [
'Grader report',
'Grade history',
'Outcomes report',
'Overview report',
'User report',
$viewstr => [
$graderpluginname,
$historypluginname,
$outcomespluginname,
$overviewpluginname,
$userpluginname,
],
'Setup' => [
'Preferences: Grader report',
$setupstr => [
$graderpreferencesstr,
],
'More' => [
'Export',
$morestr => [
$exportstr,
],
],
],
'Gradebook general navigation for student; outcomes enabled.' => [
'student',
true,
[
'View' => [
'Overview report',
'User report',
$viewstr => [
$overviewpluginname,
$userpluginname,
],
],
],
Expand Down

0 comments on commit 540ce30

Please sign in to comment.