MDL-47572 libraries: modify unittest to avoid random timing fail

Thanks to Nigel Cunningham
moodle · Oct 8, 2014 · 54f7d2d · 54f7d2d
1 parent 6597413
commit 54f7d2d
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/lib/tests/cronlib_test.php b/lib/tests/cronlib_test.php
@@ -43,7 +43,7 @@ public function cron_delete_from_temp_provider() {
         $time = 0;
 
         // Relative time stamps. Did you know data providers get executed during phpunit init?
-        $lastweekstime = -(7 * 24 * 60 * 60);
+        $lastweekstime = strtotime('-1 week') - time();
         $beforelastweekstime = $lastweekstime - 60;
         $afterlastweekstime = $lastweekstime + 60;
 
@@ -54,8 +54,8 @@ public function cron_delete_from_temp_provider() {
         // New Directory to keep.
         $nodes[] = $this->generate_test_path('/dir1/dir1_2/', true, $time, true);
 
-        // Directory exactly 1 week old, keep.
-        $nodes[] = $this->generate_test_path('/dir2/', true, $lastweekstime, true);
+        // Directory a little less than 1 week old, keep.
+        $nodes[] = $this->generate_test_path('/dir2/', true, $afterlastweekstime, true);
 
         // Directory older than 1 week old, remove.
         $nodes[] = $this->generate_test_path('/dir3/', true, $beforelastweekstime, false);