Skip to content

Commit

Permalink
MDL-79274 assignfeedback_editpdf: Fix permission error in conversion
Browse files Browse the repository at this point in the history
This was causing the adhoc task to fail with a nopermission error, when
a user was unenrolled from a course before their assignment submission
could be converted into a pdf.

Comments from MDL-56810 indicate the correct approach is to not attempt
a conversion in those cases.
  • Loading branch information
catalystfd committed Sep 6, 2023
1 parent 3fddb90 commit 57a1df5
Showing 1 changed file with 9 additions and 0 deletions.
Expand Up @@ -65,6 +65,15 @@ public function execute() {
foreach ($users as $userid) {
mtrace('Converting submission for user id ' . $userid);

// If the assignment is not vieweable, we should not try to convert the documents
// for this submission, as it will cause the adhoc task to fail with a permission
// error.
//
// Comments on MDL-56810 indicate that submission conversion should not be attempted
// if the submission is not viewable due to the user not being enrolled.
if (!$assign->can_view_submission($userid)) {
continue;
}
// Note: Before MDL-71468, the scheduled task version of this
// task would stop attempting to poll the conversion after a
// configured number of attempts were made to poll it, see:
Expand Down

0 comments on commit 57a1df5

Please sign in to comment.