MDL-69190 grade: fix slow query.

moodle · Sep 2, 2020 · 58bf730 · 58bf730
1 parent d179137
commit 58bf730
Showing 1 changed file with 1 addition and 4 deletions.
diff --git a/grade/report/grader/lib.php b/grade/report/grader/lib.php
@@ -1531,9 +1531,7 @@ public function get_right_avg_row($rows=array(), $grouponly=false) {
             // This query returns a count of ungraded grades (NULL finalgrade OR no matching record in grade_grades table)
             $sql = "SELECT gi.id, COUNT(DISTINCT u.id) AS count
                       FROM {grade_items} gi
-                      CROSS JOIN {user} u
-                      JOIN ($enrolledsql) je
-                           ON je.id = u.id
+                      CROSS JOIN ($enrolledsql) u
                       JOIN {role_assignments} ra
                            ON ra.userid = u.id
                       LEFT OUTER JOIN {grade_grades} g
@@ -1542,7 +1540,6 @@ public function get_right_avg_row($rows=array(), $grouponly=false) {
                      WHERE gi.courseid = :courseid
                            AND ra.roleid $gradebookrolessql
                            AND ra.contextid $relatedctxsql
-                           AND u.deleted = 0
                            AND g.id IS NULL
                            $groupwheresql
                   GROUP BY gi.id";