MDL-33125: core_backup: Prevent import/activity duplication from dupl…

…icating manual grade items
moodle · Nov 26, 2012 · 69b0d17 · 69b0d17
1 parent 5f1d8f2
commit 69b0d17
Showing 1 changed file with 9 additions and 0 deletions.
diff --git a/backup/moodle2/restore_stepslib.php b/backup/moodle2/restore_stepslib.php
@@ -190,6 +190,15 @@ protected function process_grade_item($data) {
                 $data->id = $newitemid = $existinggradeitem->id;
                 $DB->update_record('grade_items', $data);
             }
+        } else if ($data->itemtype == 'manual') {
+            // Manual items aren't assigned to a cm, so don't go duplicating them in the target if one exists.
+            $gi = array(
+                'itemtype' => $data->itemtype,
+                'courseid' => $data->courseid,
+                'itemname' => $data->itemname,
+                'categoryid' => $data->categoryid,
+            );
+            $newitemid = $DB->get_field('grade_items', 'id', $gi);
         }
 
         if (empty($newitemid)) {