MDL-64782 report_stats: Performance improvement

moodle · Apr 23, 2019 · 6d817db · 6d817db
1 parent 0452337
commit 6d817db
Showing 1 changed file with 4 additions and 25 deletions.
diff --git a/report/stats/classes/privacy/provider.php b/report/stats/classes/privacy/provider.php
@@ -128,36 +128,15 @@ public static function get_users_in_context(userlist $userlist) {
             return;
         }
 
-        $params = [
-            'contextid' => $context->id,
-            'contextcourse' => CONTEXT_COURSE,
-        ];
-
-        $sql = "SELECT sud.userid
-                  FROM {stats_user_daily} sud
-                  JOIN {context} ctx
-                       ON ctx.instanceid = sud.courseid
-                       AND ctx.contextlevel = :contextcourse
-                 WHERE ctx.id = :contextid";
+        $params = ['courseid' => $context->instanceid];
 
+        $sql = "SELECT userid FROM {stats_user_daily} WHERE courseid = :courseid";
         $userlist->add_from_sql('userid', $sql, $params);
 
-        $sql = "SELECT suw.userid
-                  FROM {stats_user_weekly} suw
-                  JOIN {context} ctx
-                       ON ctx.instanceid = suw.courseid
-                       AND ctx.contextlevel = :contextcourse
-                 WHERE ctx.id = :contextid";
-
+        $sql = "SELECT userid FROM {stats_user_weekly} WHERE courseid = :courseid";
         $userlist->add_from_sql('userid', $sql, $params);
 
-        $sql = "SELECT sum.userid
-                  FROM {stats_user_monthly} sum
-                  JOIN {context} ctx
-                       ON ctx.instanceid = sum.courseid
-                       AND ctx.contextlevel = :contextcourse
-                 WHERE ctx.id = :contextid";
-
+        $sql = "SELECT userid FROM {stats_user_monthly} WHERE courseid = :courseid";
         $userlist->add_from_sql('userid', $sql, $params);
     }