gradebook MDL-24682 1.9 corrected a capability check that was incorre…

…ctly allowing some users to make a course scale a standard scale
moodle · Oct 15, 2010 · 6dbefda · 6dbefda
1 parent 57e5e32
commit 6dbefda
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/grade/edit/scale/edit_form.php b/grade/edit/scale/edit_form.php
@@ -83,7 +83,8 @@ function definition_after_data() {
             if (empty($courseid)) {
                 $mform->hardFreeze('standard');
 
-            } else if (empty($scale->courseid) and !has_capability('moodle/course:managescales', get_context_instance(CONTEXT_SYSTEM))) {
+            } else if (!has_capability('moodle/course:managescales', get_context_instance(CONTEXT_SYSTEM))) {
+                //if they dont have managescales at system level the shouldnt be allowed to make scales standard (or not standard)
                 $mform->hardFreeze('standard');
 
             } else if ($used and !empty($scale->courseid)) {