MDL-19817 Migrated choose_from_menu to the new $OUTPUT->select_menu()…

… function
moodle · Jul 28, 2009 · 7110654 · 7110654
1 parent 4854006
commit 7110654
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 3 deletions.
diff --git a/mod/wiki/admin.php b/mod/wiki/admin.php
@@ -285,7 +285,12 @@
         while(list($key,$val)=each($wiki_list)) {
           $wiki_admin_list[$key."&amp;action=$action"]=$val;
         }
-        choose_from_menu($wiki_admin_list, "wikiselect", $selected, "choose", $script);
+        $selectmenu = new moodle_select_menu();
+        $selectmenu->options = $wiki_admin_list;
+        $selectmenu->name = 'wikiselect';
+        $selectmenu->selectedvalue = $selected;
+        $selectmenu->add_action('change', 'go_to_wiki');
+        echo $OUTPUT->select_menu($selectmenu);
         echo '</td>';
         echo '</tr></table>';
         echo '</fieldset></form>';

diff --git a/mod/wiki/view.php b/mod/wiki/view.php
@@ -300,8 +300,12 @@
 
         echo '<td class="sideblockheading">'
             .get_string('otherwikis', 'wiki').':&nbsp;&nbsp;';
-        $script = 'self.location=getElementById(\'otherwikis\').wikiselect.options[getElementById(\'otherwikis\').wikiselect.selectedIndex].value';
-        choose_from_menu($wiki_list, "wikiselect", $selected, "choose", $script);
+        $selectmenu = new moodle_select_menu();
+        $selectmenu->options = $wiki_list;
+        $selectmenu->name = 'wikiselect';
+        $selectmenu->selectedvalue = $selected;
+        $selectmenu->add_action('change', 'go_to_wiki');
+        echo $OUTPUT->select_menu($selectmenu);
         echo '</td>';
         echo '</tr></table>';
         echo '</form>';

diff --git a/mod/wiki/wiki.js b/mod/wiki/wiki.js
@@ -0,0 +1,3 @@
+function go_to_wiki(e, args) {
+    self.location = e.target.value;
+}