Skip to content

Commit

Permalink
MDL-77033 core_behat: Remove multilang from some scenarios
Browse files Browse the repository at this point in the history 
It should be only tested once. No need to have it in all tests.
Some steps will have to use category fullname so using tags in steps
will look ugly.
  • Loading branch information
@ilyatregubov
ilyatregubov committed Mar 30, 2023
1 parent 8b4bc3d commit 7653093
Show file tree
Hide file tree
Showing 6 changed files with 154 additions and 168 deletions.
184 changes: 91 additions & 93 deletions grade/tests/behat/grade_calculated_weights.feature
View file
Expand Up @@ -17,15 +17,13 @@ Feature: We can understand the gradebook user report
| teacher1 | C1 | editingteacher |
| student1 | C1 | student |
And the following "activities" exist:
| activity | course | idnumber | name | intro |
| assign | C1 | a1 | <span lang="en" class="multilang">EN</span><span lang="fr" class="multilang">FR</span> Test assignment one | Submit something! |
| assign | C1 | a2 | <span lang="en" class="multilang">EN</span><span lang="fr" class="multilang">FR</span> Test assignment two | Submit something! |
| assign | C1 | a3 | <span lang="en" class="multilang">EN</span><span lang="fr" class="multilang">FR</span> Test assignment three | Submit something! |
| assign | C1 | a4 | <span lang="en" class="multilang">EN</span><span lang="fr" class="multilang">FR</span> Test assignment four | Submit something! |
| assign | C1 | a5 | <span lang="en" class="multilang">EN</span><span lang="fr" class="multilang">FR</span> Test assignment five | Submit something! |
| assign | C1 | a6 | <span lang="en" class="multilang">EN</span><span lang="fr" class="multilang">FR</span> Test assignment six | Submit something! |
And the "multilang" filter is "on"
And the "multilang" filter applies to "content and headings"
| activity | course | idnumber | name | intro |
| assign | C1 | a1 | Test assignment one | Submit something! |
| assign | C1 | a2 | Test assignment two | Submit something! |
| assign | C1 | a3 | Test assignment three | Submit something! |
| assign | C1 | a4 | Test assignment four | Submit something! |
| assign | C1 | a5 | Test assignment five | Submit something! |
| assign | C1 | a6 | Test assignment six | Submit something! |
And I log in as "admin"
And I set the following administration settings values:
| grade_aggregations_visible | Mean of grades,Weighted mean of grades,Simple weighted mean of grades,Mean of grades (with extra credits),Median of grades,Lowest grade,Highest grade,Mode of grades,Natural |
Expand All @@ -34,27 +32,27 @@ Feature: We can understand the gradebook user report
And I am on "Course 1" course homepage
And I navigate to "View > Grader report" in the course gradebook
And I turn editing mode on
And I give the grade "60.00" to the user "Student 1" for the grade item "EN Test assignment one"
And I give the grade "20.00" to the user "Student 1" for the grade item "EN Test assignment two"
And I give the grade "40.00" to the user "Student 1" for the grade item "EN Test assignment three"
And I give the grade "10.00" to the user "Student 1" for the grade item "EN Test assignment four"
And I give the grade "70.00" to the user "Student 1" for the grade item "EN Test assignment five"
And I give the grade "30.00" to the user "Student 1" for the grade item "EN Test assignment six"
And I give the grade "60.00" to the user "Student 1" for the grade item "Test assignment one"
And I give the grade "20.00" to the user "Student 1" for the grade item "Test assignment two"
And I give the grade "40.00" to the user "Student 1" for the grade item "Test assignment three"
And I give the grade "10.00" to the user "Student 1" for the grade item "Test assignment four"
And I give the grade "70.00" to the user "Student 1" for the grade item "Test assignment five"
And I give the grade "30.00" to the user "Student 1" for the grade item "Test assignment six"
And I press "Save changes"
And I navigate to "Setup > Course grade settings" in the course gradebook
And I set the field "Show weightings" to "Show"
And I set the field "Show contribution to course total" to "Show"
And I press "Save changes"
And I navigate to "Setup > Gradebook setup" in the course gradebook
And I press "Add category"
And I set the field "Category name" to "<span lang=\"en\" class=\"multilang\">EN</span><span lang=\"fr\" class=\"multilang\">FR</span> Sub category"
And I set the field "Category name" to "Sub category"
And I press "Save changes"
And I click on "Move" "link" in the "EN Test assignment six" "table_row"
And I click on "Move" "link" in the "Test assignment six" "table_row"
# This xpath finds the forth last row in the table.
And I click on "Move to here" "link" in the "//tbody//tr[position()=last()-3]" "xpath_element"
And I click on "Move" "link" in the "EN Test assignment five" "table_row"
And I click on "Move" "link" in the "Test assignment five" "table_row"
And I click on "Move to here" "link" in the "//tbody//tr[position()=last()-3]" "xpath_element"
And I click on "Move" "link" in the "EN Test assignment four" "table_row"
And I click on "Move" "link" in the "Test assignment four" "table_row"
And I click on "Move to here" "link" in the "//tbody//tr[position()=last()-3]" "xpath_element"

@javascript @skip_chrome_zerosize
Expand All @@ -66,13 +64,13 @@ Feature: We can understand the gradebook user report

# Check the values in the weights column.
Then the following should exist in the "user-grade" table:
| Grade item | Calculated weight | Grade | Contribution to course total |
| EN Test assignment one | 25.00 % | 60.00 | 15.00 % |
| EN Test assignment two | 25.00 % | 20.00 | 5.00 % |
| EN Test assignment three | 25.00 % | 40.00 | 10.00 % |
| EN Test assignment four | 33.33 % | 10.00 | 0.83 % |
| EN Test assignment five | 33.33 % | 70.00 | 5.83 % |
| EN Test assignment six | 33.33 % | 30.00 | 2.50 % |
| Grade item | Calculated weight | Grade | Contribution to course total |
| Test assignment one | 25.00 % | 60.00 | 15.00 % |
| Test assignment two | 25.00 % | 20.00 | 5.00 % |
| Test assignment three | 25.00 % | 40.00 | 10.00 % |
| Test assignment four | 33.33 % | 10.00 | 0.83 % |
| Test assignment five | 33.33 % | 70.00 | 5.83 % |
| Test assignment six | 33.33 % | 30.00 | 2.50 % |

@javascript @skip_chrome_zerosize
Scenario: Weighted mean of grades aggregation
Expand All @@ -91,13 +89,13 @@ Feature: We can understand the gradebook user report

# Check the values in the weights column.
Then the following should exist in the "user-grade" table:
| Grade item | Calculated weight | Grade | Contribution to course total |
| EN Test assignment one | 40.00 % | 60.00 | 24.00 % |
| EN Test assignment two | 20.00 % | 20.00 | 4.00 % |
| EN Test assignment three | 20.00 % | 40.00 | 8.00 % |
| EN Test assignment four | 33.33 % | 10.00 | 0.67 % |
| EN Test assignment five | 33.33 % | 70.00 | 4.67 % |
| EN Test assignment six | 33.33 % | 30.00 | 2.00 % |
| Grade item | Calculated weight | Grade | Contribution to course total |
| Test assignment one | 40.00 % | 60.00 | 24.00 % |
| Test assignment two | 20.00 % | 20.00 | 4.00 % |
| Test assignment three | 20.00 % | 40.00 | 8.00 % |
| Test assignment four | 33.33 % | 10.00 | 0.67 % |
| Test assignment five | 33.33 % | 70.00 | 4.67 % |
| Test assignment six | 33.33 % | 30.00 | 2.00 % |

@javascript @skip_chrome_zerosize
Scenario: Simple weighted mean of grades aggregation
Expand All @@ -112,13 +110,13 @@ Feature: We can understand the gradebook user report

# Check the values in the weights column.
Then the following should exist in the "user-grade" table:
| Grade item | Calculated weight | Grade | Contribution to course total |
| EN Test assignment one | 33.33 % | 60.00 | 20.00 % |
| EN Test assignment two | 33.33 % | 20.00 | 6.67 % |
| EN Test assignment three | 33.33 %( Extra credit ) | 40.00 | 13.33 % |
| EN Test assignment four | 33.33 % | 10.00 | 1.11 % |
| EN Test assignment five | 33.33 % | 70.00 | 7.78 % |
| EN Test assignment six | 33.33 % | 30.00 | 3.33 % |
| Grade item | Calculated weight | Grade | Contribution to course total |
| Test assignment one | 33.33 % | 60.00 | 20.00 % |
| Test assignment two | 33.33 % | 20.00 | 6.67 % |
| Test assignment three | 33.33 %( Extra credit ) | 40.00 | 13.33 % |
| Test assignment four | 33.33 % | 10.00 | 1.11 % |
| Test assignment five | 33.33 % | 70.00 | 7.78 % |
| Test assignment six | 33.33 % | 30.00 | 3.33 % |

@javascript @skip_chrome_zerosize
Scenario: Mean of grades (with extra credits) aggregation
Expand All @@ -131,13 +129,13 @@ Feature: We can understand the gradebook user report

# Check the values in the weights column.
Then the following should exist in the "user-grade" table:
| Grade item | Calculated weight | Grade | Contribution to course total |
| EN Test assignment one | 33.33 % | 60.00 | 20.00 % |
| EN Test assignment two | 33.33 % | 20.00 | 6.67 % |
| EN Test assignment three | 33.33 %( Extra credit ) | 40.00 | 13.33 % |
| EN Test assignment four | 33.33 % | 10.00 | 1.11 % |
| EN Test assignment five | 33.33 % | 70.00 | 7.78 % |
| EN Test assignment six | 33.33 % | 30.00 | 3.33 % |
| Grade item | Calculated weight | Grade | Contribution to course total |
| Test assignment one | 33.33 % | 60.00 | 20.00 % |
| Test assignment two | 33.33 % | 20.00 | 6.67 % |
| Test assignment three | 33.33 %( Extra credit ) | 40.00 | 13.33 % |
| Test assignment four | 33.33 % | 10.00 | 1.11 % |
| Test assignment five | 33.33 % | 70.00 | 7.78 % |
| Test assignment six | 33.33 % | 30.00 | 3.33 % |

@javascript @skip_chrome_zerosize
Scenario: Median of grades aggregation
Expand All @@ -148,13 +146,13 @@ Feature: We can understand the gradebook user report

# Check the values in the weights column.
Then the following should exist in the "user-grade" table:
| Grade item | Calculated weight | Grade | Contribution to course total |
| EN Test assignment one | 0.00 % | 60.00 | 0.00 % |
| EN Test assignment two | 0.00 % | 20.00 | 0.00 % |
| EN Test assignment three | 50.00 % | 40.00 | 20.00 % |
| EN Test assignment four | 33.33 % | 10.00 | 1.67 % |
| EN Test assignment five | 33.33 % | 70.00 | 11.67 % |
| EN Test assignment six | 33.33 % | 30.00 | 5.00 % |
| Grade item | Calculated weight | Grade | Contribution to course total |
| Test assignment one | 0.00 % | 60.00 | 0.00 % |
| Test assignment two | 0.00 % | 20.00 | 0.00 % |
| Test assignment three | 50.00 % | 40.00 | 20.00 % |
| Test assignment four | 33.33 % | 10.00 | 1.67 % |
| Test assignment five | 33.33 % | 70.00 | 11.67 % |
| Test assignment six | 33.33 % | 30.00 | 5.00 % |

@javascript @skip_chrome_zerosize
Scenario: Lowest grade aggregation
Expand All @@ -165,13 +163,13 @@ Feature: We can understand the gradebook user report

# Check the values in the weights column.
Then the following should exist in the "user-grade" table:
| Grade item | Calculated weight | Grade | Contribution to course total |
| EN Test assignment one | 0.00 % | 60.00 | 0.00 % |
| EN Test assignment two | 100.00 % | 20.00 | 20.00 % |
| EN Test assignment three | 0.00 % | 40.00 | 0.00 % |
| EN Test assignment four | 33.33 % | 10.00 | 0.00 % |
| EN Test assignment five | 33.33 % | 70.00 | 0.00 % |
| EN Test assignment six | 33.33 % | 30.00 | 0.00 % |
| Grade item | Calculated weight | Grade | Contribution to course total |
| Test assignment one | 0.00 % | 60.00 | 0.00 % |
| Test assignment two | 100.00 % | 20.00 | 20.00 % |
| Test assignment three | 0.00 % | 40.00 | 0.00 % |
| Test assignment four | 33.33 % | 10.00 | 0.00 % |
| Test assignment five | 33.33 % | 70.00 | 0.00 % |
| Test assignment six | 33.33 % | 30.00 | 0.00 % |

@javascript @skip_chrome_zerosize
Scenario: Highest grade aggregation
Expand All @@ -182,13 +180,13 @@ Feature: We can understand the gradebook user report

# Check the values in the weights column.
Then the following should exist in the "user-grade" table:
| Grade item | Calculated weight | Grade | Contribution to course total |
| EN Test assignment one | 100.00 % | 60.00 | 60.00 % |
| EN Test assignment two | 0.00 % | 20.00 | 0.00 % |
| EN Test assignment three | 0.00 % | 40.00 | 0.00 % |
| EN Test assignment four | 33.33 % | 10.00 | 0.00 % |
| EN Test assignment five | 33.33 % | 70.00 | 0.00 % |
| EN Test assignment six | 33.33 % | 30.00 | 0.00 % |
| Grade item | Calculated weight | Grade | Contribution to course total |
| Test assignment one | 100.00 % | 60.00 | 60.00 % |
| Test assignment two | 0.00 % | 20.00 | 0.00 % |
| Test assignment three | 0.00 % | 40.00 | 0.00 % |
| Test assignment four | 33.33 % | 10.00 | 0.00 % |
| Test assignment five | 33.33 % | 70.00 | 0.00 % |
| Test assignment six | 33.33 % | 30.00 | 0.00 % |

@javascript @skip_chrome_zerosize
Scenario: Mode of grades aggregation
Expand All @@ -199,13 +197,13 @@ Feature: We can understand the gradebook user report

# Check the values in the weights column.
Then the following should exist in the "user-grade" table:
| Grade item | Calculated weight | Grade | Contribution to course total |
| EN Test assignment one | 100.00 % | 60.00 | 60.00 % |
| EN Test assignment two | 0.00 % | 20.00 | 0.00 % |
| EN Test assignment three | 0.00 % | 40.00 | 0.00 % |
| EN Test assignment four | 33.33 % | 10.00 | 0.00 % |
| EN Test assignment five | 33.33 % | 70.00 | 0.00 % |
| EN Test assignment six | 33.33 % | 30.00 | 0.00 % |
| Grade item | Calculated weight | Grade | Contribution to course total |
| Test assignment one | 100.00 % | 60.00 | 60.00 % |
| Test assignment two | 0.00 % | 20.00 | 0.00 % |
| Test assignment three | 0.00 % | 40.00 | 0.00 % |
| Test assignment four | 33.33 % | 10.00 | 0.00 % |
| Test assignment five | 33.33 % | 70.00 | 0.00 % |
| Test assignment six | 33.33 % | 30.00 | 0.00 % |

@javascript @skip_chrome_zerosize
Scenario: View user report with mixed aggregation methods
Expand All @@ -220,15 +218,15 @@ Feature: We can understand the gradebook user report

# Check the values in the weights column.
Then the following should exist in the "user-grade" table:
| Grade item | Calculated weight | Grade | Contribution to course total |
| EN Test assignment one | 33.33 % | 60.00 | 20.00 % |
| EN Test assignment two | 33.33 % | 20.00 | 6.67 % |
| EN Test assignment three | 33.33 %( Extra credit ) | 40.00 | 13.33 % |
| EN Test assignment four | 33.33 % | 10.00 | 1.11 % |
| EN Test assignment five | 33.33 % | 70.00 | 7.78 % |
| EN Test assignment six | 33.33 % | 30.00 | 3.33 % |
| EN Sub category totalWeighted mean of grades. | 33.33 % | 36.67 | - |
| Course total | - | 156.67 | - |
| Grade item | Calculated weight | Grade | Contribution to course total |
| Test assignment one | 33.33 % | 60.00 | 20.00 % |
| Test assignment two | 33.33 % | 20.00 | 6.67 % |
| Test assignment three | 33.33 %( Extra credit ) | 40.00 | 13.33 % |
| Test assignment four | 33.33 % | 10.00 | 1.11 % |
| Test assignment five | 33.33 % | 70.00 | 7.78 % |
| Test assignment six | 33.33 % | 30.00 | 3.33 % |
| Sub category totalWeighted mean of grades.| 33.33 % | 36.67 | - |
| Course total | - | 156.67 | - |

@javascript @skip_chrome_zerosize
Scenario: View user report with natural aggregation
Expand All @@ -239,12 +237,12 @@ Feature: We can understand the gradebook user report

# Check the values in the weights column.
Then the following should exist in the "user-grade" table:
| Grade item | Calculated weight | Grade | Contribution to course total |
| EN Test assignment one | 20.00 % | 60.00 | 12.00 % |
| EN Test assignment two | 20.00 % | 20.00 | 4.00 % |
| EN Test assignment three | 20.00 %( Extra credit ) | 40.00 | 8.00 % |
| EN Test assignment four | 33.33 % | 10.00 | 2.00 % |
| EN Test assignment five | 33.33 % | 70.00 | 14.00 % |
| EN Test assignment six | 33.33 % | 30.00 | 6.00 % |
| EN Sub category total | 60.00 % | 110.00 | - |
| Course total | - | 230.00 | - |
| Grade item | Calculated weight | Grade | Contribution to course total |
| Test assignment one | 20.00 % | 60.00 | 12.00 % |
| Test assignment two | 20.00 % | 20.00 | 4.00 % |
| Test assignment three | 20.00 %( Extra credit ) | 40.00 | 8.00 % |
| Test assignment four | 33.33 % | 10.00 | 2.00 % |
| Test assignment five | 33.33 % | 70.00 | 14.00 % |
| Test assignment six | 33.33 % | 30.00 | 6.00 % |
| Sub category total | 60.00 % | 110.00 | - |
| Course total | - | 230.00 | - |

0 comments on commit 7653093

Please sign in to comment.