Merge branch 'MDL-29296_m20' of git://github.com/rwijaya/moodle into …

…MOODLE_20_STABLE
moodle · Oct 3, 2011 · 77738c4 · 77738c4
2 parents e93dd0d + 5f32139
commit 77738c4
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 20 deletions.
diff --git a/mod/lesson/locallib.php b/mod/lesson/locallib.php
@@ -1117,7 +1117,7 @@ public function get_lastpageid() {
     }
 
      /**
-     * Gets the next page to display after the one that is provided.
+     * Gets the next page id to display after the one that is provided.
      * @param int $nextpageid
      * @return bool
      */
@@ -1126,19 +1126,19 @@ public function get_next_page($nextpageid) {
         $allpages = $this->load_all_pages();
         if ($this->properties->nextpagedefault) {
             // in Flash Card mode...first get number of retakes
-            $nretakes = $DB->count_records("lesson_grades", array("lessonid"=>$this->properties->id, "userid"=>$USER->id));
+            $nretakes = $DB->count_records("lesson_grades", array("lessonid" => $this->properties->id, "userid" => $USER->id));
             shuffle($allpages);
             $found = false;
             if ($this->properties->nextpagedefault == LESSON_UNSEENPAGE) {
                 foreach ($allpages as $nextpage) {
-                    if (!$DB->count_records("lesson_attempts", array("pageid"=>$nextpage->id, "userid"=>$USER->id, "retry"=>$nretakes))) {
+                    if (!$DB->count_records("lesson_attempts", array("pageid" => $nextpage->id, "userid" => $USER->id, "retry" => $nretakes))) {
                         $found = true;
                         break;
                     }
                 }
             } elseif ($this->properties->nextpagedefault == LESSON_UNANSWEREDPAGE) {
                 foreach ($allpages as $nextpage) {
-                    if (!$DB->count_records("lesson_attempts", array('pageid'=>$nextpage->id, 'userid'=>$USER->id, 'correct'=>1, 'retry'=>$nretakes))) {
+                    if (!$DB->count_records("lesson_attempts", array('pageid' => $nextpage->id, 'userid' => $USER->id, 'correct' => 1, 'retry' => $nretakes))) {
                         $found = true;
                         break;
                     }
@@ -1147,20 +1147,20 @@ public function get_next_page($nextpageid) {
             if ($found) {
                 if ($this->properties->maxpages) {
                     // check number of pages viewed (in the lesson)
-                    if ($DB->count_records("lesson_attempts", array("lessonid"=>$this->properties->id, "userid"=>$USER->id, "retry"=>$nretakes)) >= $this->properties->maxpages) {
+                    if ($DB->count_records("lesson_attempts", array("lessonid" => $this->properties->id, "userid" => $USER->id, "retry" => $nretakes)) >= $this->properties->maxpages) {
-                        return false;
+                        return LESSON_EOL;
                     }
                 }
-                return $nextpage;
+                return $nextpage->id;
             }
         }
         // In a normal lesson mode
         foreach ($allpages as $nextpage) {
-            if ((int)$nextpage->id===(int)$nextpageid) {
+            if ((int)$nextpage->id === (int)$nextpageid) {
-                return $nextpage;
+                return $nextpage->id;
             }
         }
-        return false;
+        return LESSON_EOL;
     }
 
     /**
@@ -1985,12 +1985,7 @@ final public function record_attempt($context) {
             if ($result->newpageid == 0) {
                 $result->newpageid = $this->properties->id;
             } elseif ($result->newpageid == LESSON_NEXTPAGE) {
-                $nextpage = $this->lesson->get_next_page($this->properties->nextpageid);
+                $result->newpageid = $this->lesson->get_next_page($this->properties->nextpageid);
-                if ($nextpage === false) {
-                    $result->newpageid = LESSON_EOL;
-                } else {
-                    $result->newpageid = $nextpage->id;
-                }
             }
 
             // Determine default feedback if necessary

diff --git a/mod/lesson/view.php b/mod/lesson/view.php
@@ -374,10 +374,7 @@
         $data = new stdClass;
         $data->id = $PAGE->cm->id;
         $data->pageid = $page->id;
-        $data->newpageid = LESSON_NEXTPAGE;
+        $data->newpageid = $lesson->get_next_page($page->nextpageid);
-        if ($nextpage = $lesson->get_next_page($page->nextpageid)) {
-            $data->newpageid = $nextpage->id;
-        }
 
         $customdata = array(
             'title'     => $page->title,