Skip to content

Commit

Permalink
MDL-69883 message: fix lazy loading of conversations.
Browse files Browse the repository at this point in the history
Set max-height on each container section rather than the container
itself, so that each can respond to the scrollBottom event within
the lazy loading module (which handles the overflow itself).
  • Loading branch information
paulholden committed Feb 24, 2021
1 parent af00404 commit 7aee6e2
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 8 deletions.
5 changes: 3 additions & 2 deletions theme/boost/scss/moodle/message.scss
Expand Up @@ -659,8 +659,9 @@ $message-day-color: color-yiq($message-app-bg) !default;
height: 100%;
margin-top: 0;
.conversationcontainer {
max-height: calc(100vh - 50px);
overflow: auto;
.section {
max-height: calc(100vh - 50px);
}
}
div[role="main"] {
height: 100%;
Expand Down
5 changes: 2 additions & 3 deletions theme/boost/style/moodle.css
Expand Up @@ -15468,9 +15468,8 @@ a.ygtvspacer:hover {
#page-message-index #region-main {
height: 100%;
margin-top: 0; }
#page-message-index #region-main .conversationcontainer {
max-height: calc(100vh - 50px);
overflow: auto; }
#page-message-index #region-main .conversationcontainer .section {
max-height: calc(100vh - 50px); }
#page-message-index #region-main div[role="main"] {
height: 100%; }
#page-message-index #region-main div[role="main"] #maincontent {
Expand Down
5 changes: 2 additions & 3 deletions theme/classic/style/moodle.css
Expand Up @@ -15684,9 +15684,8 @@ a.ygtvspacer:hover {
#page-message-index #region-main {
height: 100%;
margin-top: 0; }
#page-message-index #region-main .conversationcontainer {
max-height: calc(100vh - 50px);
overflow: auto; }
#page-message-index #region-main .conversationcontainer .section {
max-height: calc(100vh - 50px); }
#page-message-index #region-main div[role="main"] {
height: 100%; }
#page-message-index #region-main div[role="main"] #maincontent {
Expand Down

0 comments on commit 7aee6e2

Please sign in to comment.