Skip to content

Commit

Permalink
MDL-35238 Remove the hide/show icon from the Plugins overview page
Browse files Browse the repository at this point in the history
This was reported in forums as an usability issue. This icon is used
across Moodle as an active link to hide or show things - not as a status
icon. People were trying to disable plugins by clicking the icon. Until
there is a full support for doing this from the Plugins overview page,
it is better to remove the icons completely.
  • Loading branch information
mudrd8mz committed Nov 8, 2012
1 parent 4df8bce commit 7bc759b
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions admin/renderer.php
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -1065,12 +1065,10 @@ public function plugins_control_panel(plugin_manager $pluginman, array $options
$availability = new html_table_cell(''); $availability = new html_table_cell('');
} else if ($isenabled) { } else if ($isenabled) {
$row->attributes['class'] .= ' enabled'; $row->attributes['class'] .= ' enabled';
$icon = $this->output->pix_icon('i/hide', get_string('pluginenabled', 'core_plugin')); $availability = new html_table_cell(get_string('pluginenabled', 'core_plugin'));
$availability = new html_table_cell($icon . ' ' . get_string('pluginenabled', 'core_plugin'));
} else { } else {
$row->attributes['class'] .= ' disabled'; $row->attributes['class'] .= ' disabled';
$icon = $this->output->pix_icon('i/show', get_string('plugindisabled', 'core_plugin')); $availability = new html_table_cell(get_string('plugindisabled', 'core_plugin'));
$availability = new html_table_cell($icon . ' ' . get_string('plugindisabled', 'core_plugin'));
} }


$actions = array(); $actions = array();
Expand Down

0 comments on commit 7bc759b

Please sign in to comment.