Skip to content

Commit

Permalink
MDL-36942 xml question import: don't add spaces.
Browse files Browse the repository at this point in the history
They are not necessary anyway, there is a \n character at the end of
each line.

Thanks to Richard Lobb for fining the problem and how to fix it.
  • Loading branch information
timhunt committed Nov 30, 2012
1 parent 47dfbd9 commit 7e252ac
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions question/format/xml/format.php
Expand Up @@ -905,17 +905,18 @@ protected function import_category($question) {
*/
protected function readquestions($lines) {
// We just need it as one big string
$text = implode($lines, ' ');
unset($lines);
$lines = implode('', $lines);

// This converts xml to big nasty data structure
// the 0 means keep white space as it is (important for markdown format)
try {
$xml = xmlize($text, 0, 'UTF-8', true);
$xml = xmlize($lines, 0, 'UTF-8', true);
} catch (xml_format_exception $e) {
$this->error($e->getMessage(), '');
return false;
}
unset($lines); // No need to keep this in memory.

// Set up array to hold all our questions
$questions = array();

Expand Down

0 comments on commit 7e252ac

Please sign in to comment.