Skip to content

Commit

Permalink
MDL-74394 mnet: Better check for openssl_get_publickey() failure
Browse files Browse the repository at this point in the history
In PHP8, this func now returns an object of type OpenSSLAsymmetricKey, not a
resource.

Reference:
https://www.php.net/manual/en/function.openssl-pkey-get-public.php
  • Loading branch information
aolley committed Apr 1, 2022
1 parent 3ab09c7 commit 7e29aee
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion mnet/lib.php
Expand Up @@ -259,7 +259,7 @@ function mnet_encrypt_message($message, $remote_certificate) {
// Generate a key resource from the remote_certificate text string
$publickey = openssl_get_publickey($remote_certificate);

if ( gettype($publickey) != 'resource' ) {
if ($publickey === false) {
// Remote certificate is faulty.
return false;
}
Expand Down

0 comments on commit 7e29aee

Please sign in to comment.