MDL-12192 temporarily disabled support for colonized labels

The code must be fixed so that the colon is not displayed when the label is hidden by accessibility CSS.
moodle · Sep 24, 2010 · 81e62b6 · 81e62b6
1 parent 682a192
commit 81e62b6
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/lang/en/langconfig.php b/lang/en/langconfig.php
@@ -29,7 +29,7 @@
 $string['firstdayofweek'] = '0';
 $string['iso6391'] = 'en';
 $string['iso6392'] = 'eng';
-$string['labelsep'] = '&nbsp;';
+$string['labelsep'] = ': ';
 $string['listsep'] = ',';
 $string['locale'] = 'en_AU.UTF-8';
 $string['localewin'] = 'English_Australia.1252';

diff --git a/lib/outputcomponents.php b/lib/outputcomponents.php
@@ -1373,6 +1373,8 @@ public static function label($text, $for, $colonize=true, array $attributes=arra
         $text = trim($text);
         $label = self::tag('label', $text, $attributes);
 
+        /*
+        // TODO $colonize disabled for now yet - see MDL-12192 for details
         if (!empty($text) and $colonize) {
             // the $text may end with the colon already, though it is bad string definition style
             $colon = get_string('labelsep', 'langconfig');
@@ -1386,6 +1388,7 @@ public static function label($text, $for, $colonize=true, array $attributes=arra
                 }
             }
         }
+        */
 
         return $label;
     }