MDL-34240 - google plugins: switch to PARAM_RAW_TRIMMED

This ensures the client credentials which are entered are trimmed as users are finding problems with bad pastes.
moodle · Jul 13, 2012 · 8811181 · 8811181
1 parent f2867a8
commit 8811181
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 0 deletions.
diff --git a/portfolio/googledocs/lib.php b/portfolio/googledocs/lib.php
@@ -108,7 +108,9 @@ public static function admin_config_form(&$mform) {
         $mform->addElement('static', null, '', get_string('oauthinfo', 'portfolio_googledocs', $a));
 
         $mform->addElement('text', 'clientid', get_string('clientid', 'portfolio_googledocs'));
+        $mform->setType('clientid', PARAM_RAW_TRIMMED);
         $mform->addElement('text', 'secret', get_string('secret', 'portfolio_googledocs'));
+        $mform->setType('secret', PARAM_RAW_TRIMMED);
 
         $strrequired = get_string('required');
         $mform->addRule('clientid', $strrequired, 'required', null, 'client');

diff --git a/portfolio/picasa/lib.php b/portfolio/picasa/lib.php
@@ -108,7 +108,9 @@ public static function admin_config_form(&$mform) {
         $mform->addElement('static', null, '', get_string('oauthinfo', 'portfolio_picasa', $a));
 
         $mform->addElement('text', 'clientid', get_string('clientid', 'portfolio_picasa'));
+        $mform->setType('clientid', PARAM_RAW_TRIMMED);
         $mform->addElement('text', 'secret', get_string('secret', 'portfolio_picasa'));
+        $mform->setType('secret', PARAM_RAW_TRIMMED);
 
         $strrequired = get_string('required');
         $mform->addRule('clientid', $strrequired, 'required', null, 'client');

diff --git a/repository/googledocs/lib.php b/repository/googledocs/lib.php
@@ -119,7 +119,9 @@ public static function type_config_form($mform, $classname = 'repository') {
 
         parent::type_config_form($mform);
         $mform->addElement('text', 'clientid', get_string('clientid', 'repository_googledocs'));
+        $mform->setType('clientid', PARAM_RAW_TRIMMED);
         $mform->addElement('text', 'secret', get_string('secret', 'repository_googledocs'));
+        $mform->setType('secret', PARAM_RAW_TRIMMED);
 
         $strrequired = get_string('required');
         $mform->addRule('clientid', $strrequired, 'required', null, 'client');

diff --git a/repository/picasa/lib.php b/repository/picasa/lib.php
@@ -121,7 +121,9 @@ public static function type_config_form($mform, $classname = 'repository') {
 
         parent::type_config_form($mform);
         $mform->addElement('text', 'clientid', get_string('clientid', 'repository_picasa'));
+        $mform->setType('clientid', PARAM_RAW_TRIMMED);
         $mform->addElement('text', 'secret', get_string('secret', 'repository_picasa'));
+        $mform->setType('secret', PARAM_RAW_TRIMMED);
 
         $strrequired = get_string('required');
         $mform->addRule('clientid', $strrequired, 'required', null, 'client');