MDL-33765 filter_glossary: fixed jshint warning

moodle · Jun 29, 2015 · 8e7774f · 8e7774f
1 parent a42f94a
commit 8e7774f
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 10 deletions.
diff --git a/...ry/yui/build/moodle-filter_glossary-autolinker/moodle-filter_glossary-autolinker-debug.js b/...ry/yui/build/moodle-filter_glossary-autolinker/moodle-filter_glossary-autolinker-debug.js
@@ -83,9 +83,7 @@ Y.extend(AUTOLINKER, Y.Base, {
 
                     // Register alertpanel for stacking.
                     alertpanelid = '#moodle-dialogue-' + alertpanel.get('COUNT');
-                    alertpanel.on('complete', function(){
-                        delete self.alertpanels[alertpanelid];
-                    });
+                    alertpanel.on('complete', this._deletealertpanel(self.alertpanels, alertpanelid));
 
                     // We already have some windows opened, so set the right position...
                     if (!Y.Object.isEmpty(this.alertpanels)){
@@ -113,6 +111,9 @@ Y.extend(AUTOLINKER, Y.Base, {
             }
         });
         return lastPosition;
+    },
+    _deletealertpanel : function(alertpanels, alertpanelid) {
+        delete alertpanels[alertpanelid];
     }
 }, {
     NAME : AUTOLINKERNAME,

diff --git a/...sary/yui/build/moodle-filter_glossary-autolinker/moodle-filter_glossary-autolinker-min.js b/...sary/yui/build/moodle-filter_glossary-autolinker/moodle-filter_glossary-autolinker-min.js
diff --git a/...glossary/yui/build/moodle-filter_glossary-autolinker/moodle-filter_glossary-autolinker.js b/...glossary/yui/build/moodle-filter_glossary-autolinker/moodle-filter_glossary-autolinker.js
@@ -83,9 +83,7 @@ Y.extend(AUTOLINKER, Y.Base, {
 
                     // Register alertpanel for stacking.
                     alertpanelid = '#moodle-dialogue-' + alertpanel.get('COUNT');
-                    alertpanel.on('complete', function(){
-                        delete self.alertpanels[alertpanelid];
-                    });
+                    alertpanel.on('complete', this._deletealertpanel(self.alertpanels, alertpanelid));
 
                     // We already have some windows opened, so set the right position...
                     if (!Y.Object.isEmpty(this.alertpanels)){
@@ -113,6 +111,9 @@ Y.extend(AUTOLINKER, Y.Base, {
             }
         });
         return lastPosition;
+    },
+    _deletealertpanel : function(alertpanels, alertpanelid) {
+        delete alertpanels[alertpanelid];
     }
 }, {
     NAME : AUTOLINKERNAME,

diff --git a/filter/glossary/yui/src/autolinker/js/autolinker.js b/filter/glossary/yui/src/autolinker/js/autolinker.js
@@ -81,9 +81,7 @@ Y.extend(AUTOLINKER, Y.Base, {
 
                     // Register alertpanel for stacking.
                     alertpanelid = '#moodle-dialogue-' + alertpanel.get('COUNT');
-                    alertpanel.on('complete', function(){
-                        delete self.alertpanels[alertpanelid];
-                    });
+                    alertpanel.on('complete', this._deletealertpanel(self.alertpanels, alertpanelid));
 
                     // We already have some windows opened, so set the right position...
                     if (!Y.Object.isEmpty(this.alertpanels)){
@@ -111,6 +109,9 @@ Y.extend(AUTOLINKER, Y.Base, {
             }
         });
         return lastPosition;
+    },
+    _deletealertpanel : function(alertpanels, alertpanelid) {
+        delete alertpanels[alertpanelid];
     }
 }, {
     NAME : AUTOLINKERNAME,