blog MDL-23393 - Tidy up preferences form

Make form display set value and use mforms type checking
moodle · Jan 9, 2011 · 9268148 · 9268148
1 parent 46f4c39
commit 9268148
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/blog/preferences.php b/blog/preferences.php
@@ -73,6 +73,7 @@
 /// If data submitted, then process and store.
 
 $mform = new blog_preferences_form('preferences.php');
+$mform->set_data(array('pagesize' => get_user_preferences('blogpagesize')));
 
 if (!$mform->is_cancelled() && $data = $mform->get_data()) {
     $pagesize = $data->pagesize;

diff --git a/blog/preferences_form.php b/blog/preferences_form.php
@@ -39,7 +39,9 @@ public function definition() {
         $strpagesize = get_string('pagesize', 'blog');
 
         $mform->addElement('text', 'pagesize', $strpagesize);
-        $mform->setDefault('pagesize', get_user_preferences('pagesize'));
+        $mform->setType('pagesize', PARAM_INT);
+        $mform->addRule('pagesize', null, 'numeric', null, 'client');
+        $mform->setDefault('pagesize', 10);
 
         $this->add_action_buttons();
     }