MDL-27625 rating - consider RATING_UNSET_RATING a valid rating value

moodle · May 25, 2011 · 93e980d · 93e980d
1 parent a021f72
commit 93e980d
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 6 deletions.
diff --git a/mod/data/lib.php b/mod/data/lib.php
@@ -1420,9 +1420,14 @@ function data_rating_validate($params) {
     }
 
     //check that the submitted rating is valid for the scale
-    if ($params['rating'] < 0) {
+
+    // lower limit
+    if ($params['rating'] < 0  && $params['rating'] != RATING_UNSET_RATING) {
         throw new rating_exception('invalidnum');
-    } else if ($info->scale < 0) {
+    }
+
+    // upper limit
+    if ($info->scale < 0) {
         //its a custom scale
         $scalerecord = $DB->get_record('scale', array('id' => -$params['scaleid']));
         if ($scalerecord) {

diff --git a/mod/forum/lib.php b/mod/forum/lib.php
@@ -3513,9 +3513,14 @@ function forum_rating_validate($params) {
     }
 
     //check that the submitted rating is valid for the scale
-    if ($params['rating'] < 0) {
+
+    // lower limit
+    if ($params['rating'] < 0  && $params['rating'] != RATING_UNSET_RATING) {
         throw new rating_exception('invalidnum');
-    } else if ($info->scale < 0) {
+    }
+
+    // upper limit
+    if ($info->scale < 0) {
         //its a custom scale
         $scalerecord = $DB->get_record('scale', array('id' => -$params['scaleid']));
         if ($scalerecord) {

diff --git a/mod/glossary/lib.php b/mod/glossary/lib.php
@@ -526,9 +526,14 @@ function glossary_rating_validate($params) {
     }
 
     //check that the submitted rating is valid for the scale
-    if ($params['rating'] < 0) {
+
+    // lower limit
+    if ($params['rating'] < 0  && $params['rating'] != RATING_UNSET_RATING) {
         throw new rating_exception('invalidnum');
-    } else if ($info->scale < 0) {
+    }
+
+    // upper limit
+    if ($info->scale < 0) {
         //its a custom scale
         $scalerecord = $DB->get_record('scale', array('id' => -$params['scaleid']));
         if ($scalerecord) {