Merge branch 'MDL-80656-401' of https://github.com/lameze/moodle into…

… MOODLE_401_STABLE
moodle · Jan 25, 2024 · 95c3017 · 95c3017
2 parents 8fffc08 + ca7b24f
commit 95c3017
Showing 1 changed file with 8 additions and 14 deletions.
diff --git a/mod/lesson/tests/behat/lesson_informations_at_end.feature b/mod/lesson/tests/behat/lesson_informations_at_end.feature
@@ -34,19 +34,9 @@ Feature: In a lesson activity, if custom scoring is not enabled, student should
       | Maximum grade  | 75 |
       | Custom scoring | No    |
     And I press "Save and display"
-    And I am on "Course 1" course homepage with editing mode on
-    And I duplicate "Test lesson name" activity
-    And I wait until section "1" is available
-    And I am on the "Test lesson name (copy)" "lesson activity editing" page
-    And I set the field "Name" to "Test lesson name 2"
-    And I set the field "grade[modgrade_type]" to "Scale"
-    And I set the field "Scale" to "Test Scale"
-    And I press "Save and return to course"
-    And I log out
-    And I log in as "student1"
 
   Scenario: Informations at end of lesson if custom scoring not enabled
-    Given I am on the "Test lesson name" "lesson activity" page
+    Given I am on the "Test lesson name" "lesson activity" page logged in as student1
     And I should see "First page contents"
     When I press "Next page"
     And I should see "1 + 1?"
@@ -65,7 +55,7 @@ Feature: In a lesson activity, if custom scoring is not enabled, student should
     Given the following "language customisations" exist:
       | component       | stringid | value |
       | core_langconfig | decsep   | #     |
-    And I am on the "Test lesson name" "lesson activity" page
+    And I am on the "Test lesson name" "lesson activity" page logged in as student1
     And I should see "First page contents"
     When I press "Next page"
     And I should see "1 + 1?"
@@ -81,8 +71,12 @@ Feature: In a lesson activity, if custom scoring is not enabled, student should
     And I should see "Your current grade is 0#0 out of 75"
 
   Scenario: Current grade is displayed at end of lesson when grade type is set to scale
-    Given I am on the "Test lesson name 2" "lesson activity" page
-    When I press "Next page"
+    Given I am on the "Test lesson name" "lesson activity editing" page logged in as teacher1
+    And I set the field "grade[modgrade_type]" to "Scale"
+    And I set the field "Scale" to "Test Scale"
+    And I press "Save and return to course"
+    When I am on the "Test lesson name" "lesson activity" page logged in as student1
+    And I press "Next page"
     And I should see "1 + 1?"
     And I set the following fields to these values:
       | Your answer | 2 |