Skip to content

Commit

Permalink
MDL-62738: editor_tinymce: Fix call stack size bug on Safari
Browse files Browse the repository at this point in the history
The call stack size was being exceeded via a recursive loop brought
by MDL-61189.

To fix, this item removes MDL-36803 and MDL-41328 as the iOS keyboard works
nicely now on Safari with TinyMCE.
  • Loading branch information
Marcus Fabriczy committed Oct 6, 2018
1 parent 7daf207 commit 975c91d
Showing 1 changed file with 0 additions and 22 deletions.
22 changes: 0 additions & 22 deletions lib/editor/tinymce/module.js
Original file line number Diff line number Diff line change
Expand Up @@ -59,28 +59,6 @@ M.editor_tinymce.init_editor = function(Y, editorid, options) {
}
}

// We have to override the editor setup to work around a bug in iOS browsers - MDL-36803.
if (Y.UA.ios) {
// Retain any setup which is already defined.
options.originalSetupFunction = options.setup || function(){};
options.setup = function(editor) {
options.originalSetupFunction();
editor.onPostRender.add(function(ed) {
// Whenever there is a keydown event, ensure that the contentWindow still have focus.
ed.contentDocument.addEventListener('keydown', function() {
ed.contentWindow.focus();
});

// Whenever a touch event is registered against the content document,
// reapply focus. This works around an issue with the location caret not
// being focusable without use of the Loupe.
ed.contentDocument.addEventListener('touchend', function() {
ed.contentWindow.focus();
});
});
};
}

// Retain any setup which is already defined.
options.originalSetupFunction = options.setup || function(){};
options.setup = function(editor) {
Expand Down

0 comments on commit 975c91d

Please sign in to comment.