MDL-53452 tool_lp: Rename get_course_settings to get_by_courseid

In the course_competency_settings persistent.
moodle · Apr 18, 2016 · 9919b4a · 9919b4a
1 parent 9785dd8
commit 9919b4a
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 10 deletions.
diff --git a/admin/tool/lp/classes/api.php b/admin/tool/lp/classes/api.php
@@ -4212,7 +4212,7 @@ public static function add_evidence($userid,
                     }
 
                     // Check the course settings to see if we should push to user plans.
-                    $coursesettings = course_competency_settings::get_course_settings($courseid);
+                    $coursesettings = course_competency_settings::get_by_courseid($courseid);
                     $setucgrade = $coursesettings->get_pushratingstouserplans();
 
                     if ($setucgrade) {
@@ -4276,7 +4276,7 @@ public static function add_evidence($userid,
                     // Set proficiency.
                     $usercompetencycourse->set_proficiency($proficiency);
 
-                    $coursesettings = course_competency_settings::get_course_settings($courseid);
+                    $coursesettings = course_competency_settings::get_by_courseid($courseid);
                     if (!$coursesettings->get_pushratingstouserplans()) {
                         $setucgrade = false;
                     }
@@ -4872,7 +4872,7 @@ public static function read_course_competency_settings($courseid) {
             throw new required_capability_exception($context, 'tool/lp:coursecompetencyview', 'nopermissions', '');
         }
 
-        return course_competency_settings::get_course_settings($courseid);
+        return course_competency_settings::get_by_courseid($courseid);
     }
 
     /**

diff --git a/admin/tool/lp/classes/course_competency_settings.php b/admin/tool/lp/classes/course_competency_settings.php
@@ -61,7 +61,7 @@ protected static function define_properties() {
      * @param int $courseid The course id
      * @return course_competency_settings
      */
-    public static function get_course_settings($courseid) {
+    public static function get_by_courseid($courseid) {
         global $DB;
 
         $params = array(

diff --git a/admin/tool/lp/tests/course_competency_settings_test.php b/admin/tool/lp/tests/course_competency_settings_test.php
@@ -76,21 +76,21 @@ public function test_who_can_change_settings() {
 
         set_config('pushcourseratingstouserplans', true, 'tool_lp');
 
-        $coursesettings = course_competency_settings::get_course_settings($c1->id);
+        $coursesettings = course_competency_settings::get_by_courseid($c1->id);
         $this->assertTrue((boolean)$coursesettings->get_pushratingstouserplans());
 
         set_config('pushcourseratingstouserplans', false, 'tool_lp');
 
-        $coursesettings = course_competency_settings::get_course_settings($c1->id);
+        $coursesettings = course_competency_settings::get_by_courseid($c1->id);
         $this->assertFalse((boolean)$coursesettings->get_pushratingstouserplans());
 
         api::update_course_competency_settings($c1->id, (object) array('pushratingstouserplans' => true));
-        $coursesettings = course_competency_settings::get_course_settings($c1->id);
+        $coursesettings = course_competency_settings::get_by_courseid($c1->id);
         $this->assertTrue((boolean)$coursesettings->get_pushratingstouserplans());
 
         set_config('pushcourseratingstouserplans', true, 'tool_lp');
         api::update_course_competency_settings($c1->id, (object) array('pushratingstouserplans' => false));
-        $coursesettings = course_competency_settings::get_course_settings($c1->id);
+        $coursesettings = course_competency_settings::get_by_courseid($c1->id);
         $this->assertFalse((boolean)$coursesettings->get_pushratingstouserplans());
 
         // Right now the setting is false.

diff --git a/admin/tool/lp/tests/externallib_test.php b/admin/tool/lp/tests/externallib_test.php
@@ -3080,13 +3080,13 @@ public function test_update_course_competency_settings() {
         // Start the test.
         $result = external::update_course_competency_settings($course->id, array('pushratingstouserplans' => true));
 
-        $settings = course_competency_settings::get_course_settings($course->id);
+        $settings = course_competency_settings::get_by_courseid($course->id);
 
         $this->assertTrue((bool)$settings->get_pushratingstouserplans());
 
         $result = external::update_course_competency_settings($course->id, array('pushratingstouserplans' => false));
 
-        $settings = course_competency_settings::get_course_settings($course->id);
+        $settings = course_competency_settings::get_by_courseid($course->id);
 
         $this->assertFalse((bool)$settings->get_pushratingstouserplans());
         $this->setUser($compnoob);