MDL-70725 oauth2: move expectException to separate method

moodle · Jan 27, 2021 · 9975f5e · 9975f5e
1 parent fd840ab
commit 9975f5e
Showing 1 changed file with 11 additions and 3 deletions.
diff --git a/lib/tests/oauth2_test.php b/lib/tests/oauth2_test.php
@@ -44,9 +44,6 @@ public function test_create_and_delete_standard_issuers() {
         \core\oauth2\api::create_standard_issuer('microsoft');
         \core\oauth2\api::create_standard_issuer('nextcloud', 'https://dummy.local/nextcloud/');
 
-        $this->expectException(\moodle_exception::class);
-        \core\oauth2\api::create_standard_issuer('nextcloud');
-
         $issuers = \core\oauth2\api::get_all_issuers();
 
         $this->assertEquals($issuers[0]->get('name'), 'Google');
@@ -72,6 +69,17 @@ public function test_create_and_delete_standard_issuers() {
         $this->assertEquals($issuers[2]->get('name'), 'Nextcloud');
     }
 
+    /**
+     * Tests the crud operations on oauth2 issuers.
+     */
+    public function test_create_nextcloud_without_url() {
+        $this->resetAfterTest();
+        $this->setAdminUser();
+
+        $this->expectException(\moodle_exception::class);
+        \core\oauth2\api::create_standard_issuer('nextcloud');
+    }
+
     /**
      * Tests we can list and delete each of the persistents related to an issuer.
      */