MDL-79980 mod_survey: remove responses link if user cannot access.

moodle · Dec 7, 2023 · 9badb9e · 9badb9e
1 parent c142ad2
commit 9badb9e
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/mod/survey/lib.php b/mod/survey/lib.php
@@ -808,7 +808,16 @@ function survey_supports($feature) {
 function survey_extend_settings_navigation($settings, $surveynode) {
     global $PAGE;
 
-    if (has_capability('mod/survey:readresponses', $PAGE->cm->context)) {
+    $cm = get_coursemodule_from_id('survey', $PAGE->cm->id);
+    $context = context_module::instance($cm->id);
+
+     // Check to see if groups are being used in this survey, confirm user can access.
+    $groupmode = groups_get_activity_groupmode($cm);
+    $currentgroup = groups_get_activity_group($cm, true);
+
+    if (has_capability('mod/survey:readresponses', $context) &&
+            !($currentgroup === 0 && $groupmode == SEPARATEGROUPS && !has_capability('moodle/site:accessallgroups', $context))) {
+
         $responsesnode = $surveynode->add(get_string("responsereports", "survey"));
 
         $url = new moodle_url('/mod/survey/report.php', array('id' => $PAGE->cm->id, 'action'=>'summary'));

diff --git a/mod/survey/view.php b/mod/survey/view.php
@@ -83,7 +83,10 @@
     $currentgroup = 0;
 }
 
-if (has_capability('mod/survey:readresponses', $context)) {
+$currentactivitygroup = groups_get_activity_group($cm, true);
+if (has_capability('mod/survey:readresponses', $context) &&
+        !($currentactivitygroup === 0 && $groupmode == SEPARATEGROUPS && !has_capability('moodle/site:accessallgroups', $context))) {
+
     $numusers = survey_count_responses($survey->id, $currentgroup, $groupingid);
     echo "<div class=\"reportlink\"><a href=\"report.php?id=$cm->id\">".
           get_string("viewsurveyresponses", "survey", $numusers)."</a></div>";