MDL-72720 qbehaviour: Implement enable_plugin() method

moodle · Oct 15, 2021 · a22093d · a22093d
1 parent 5009021
commit a22093d
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 8 deletions.
diff --git a/admin/qbehaviours.php b/admin/qbehaviours.php
@@ -88,10 +88,9 @@
     }
 
     if (array_search($disable, $disabledbehaviours) === false) {
-        $disabledbehaviours[] = $disable;
-        set_config('disabledbehaviours', implode(',', $disabledbehaviours), 'question');
+        $class = \core_plugin_manager::resolve_plugininfo_class('qbehaviour');
+        $class::enable_plugin($disable, false);
     }
-    core_plugin_manager::reset_caches();
     redirect($thispageurl);
 }
 
@@ -106,10 +105,9 @@
     }
 
     if (($key = array_search($enable, $disabledbehaviours)) !== false) {
-        unset($disabledbehaviours[$key]);
-        set_config('disabledbehaviours', implode(',', $disabledbehaviours), 'question');
+        $class = \core_plugin_manager::resolve_plugininfo_class('qbehaviour');
+        $class::enable_plugin($enable, true);
     }
-    core_plugin_manager::reset_caches();
     redirect($thispageurl);
 }
 
@@ -238,4 +236,3 @@ function question_behaviour_icon_html($action, $behaviour, $icon, $alt, $tip) {
             new pix_icon($icon, $alt, 'moodle', array('title' => '', 'class' => 'iconsmall')),
             null, array('title' => $tip));
 }
-
diff --git a/lib/classes/plugininfo/qbehaviour.php b/lib/classes/plugininfo/qbehaviour.php
@@ -57,6 +57,33 @@ public static function get_enabled_plugins() {
         return $enabled;
     }
 
+    public static function enable_plugin(string $pluginname, int $enabled): bool {
+        $haschanged = false;
+        $plugins = [];
+        $oldvalue = get_config('question', 'disabledbehaviours');
+        if (!empty($oldvalue)) {
+            $plugins = array_flip(explode(',', $oldvalue));
+        }
+        // Only set visibility if it's different from the current value.
+        if ($enabled && array_key_exists($pluginname, $plugins)) {
+            unset($plugins[$pluginname]);
+            $haschanged = true;
+        } else if (!$enabled && !array_key_exists($pluginname, $plugins)) {
+            $plugins[$pluginname] = $pluginname;
+            $haschanged = true;
+        }
+
+        if ($haschanged) {
+            $new = implode(',', array_flip($plugins));
+            add_to_config_log('disabledbehaviours', $oldvalue, $new, 'question');
+            set_config('disabledbehaviours', $new, 'question');
+            // Reset caches.
+            \core_plugin_manager::reset_caches();
+        }
+
+        return $haschanged;
+    }
+
     public function is_uninstall_allowed() {
         global $DB;
 
@@ -110,4 +137,3 @@ public static function get_manage_url() {
         return new moodle_url('/admin/qbehaviours.php');
     }
 }
-