Merge branch 'MDL-79274_402' of https://github.com/catalystfd/moodle …

…into MOODLE_402_STABLE
moodle · Sep 28, 2023 · a3dfbe4 · a3dfbe4
2 parents b1680c4 + 6c65bee
commit a3dfbe4
Showing 1 changed file with 9 additions and 0 deletions.
diff --git a/mod/assign/feedback/editpdf/classes/task/convert_submission.php b/mod/assign/feedback/editpdf/classes/task/convert_submission.php
@@ -65,6 +65,15 @@ public function execute() {
         foreach ($users as $userid) {
             mtrace('Converting submission for user id ' . $userid);
 
+            // If the assignment is not vieweable, we should not try to convert the documents
+            // for this submission, as it will cause the adhoc task to fail with a permission
+            // error.
+            //
+            // Comments on MDL-56810 indicate that submission conversion should not be attempted
+            // if the submission is not viewable due to the user not being enrolled.
+            if (!$assign->can_view_submission($userid)) {
+                continue;
+            }
             // Note: Before MDL-71468, the scheduled task version of this
             // task would stop attempting to poll the conversion after a
             // configured number of attempts were made to poll it, see: