Merge branch 'MDL-67696-MOODLE_38_STABLE_count_warning' of https://gi…

…thub.com/JayChurchward/moodle into MOODLE_38_STABLE

mod/forum/classes/task/refresh_forum_post_counts.php

@@ -54,9 +54,12 @@ public function execute() {
     protected function update_null_forum_post_counts(): bool {
         global $CFG, $DB;
 
-        // Default to chunks of 5000 records per run, unless overridden in config.php
+        // Default to chunks of 5000 records per run, unless overridden in config.php.
         $chunksize = $CFG->forumpostcountchunksize ?? 5000;
 
+        // Initialize counter.
+        $recordscount = 0;
+
         $select = 'wordcount IS NULL OR charcount IS NULL';
         $recordset = $DB->get_recordset_select('forum_posts', $select, null, 'discussion', 'id, message', 0, $chunksize);
 
@@ -68,9 +71,9 @@ protected function update_null_forum_post_counts(): bool {
         foreach ($recordset as $record) {
             \mod_forum\local\entities\post::add_message_counts($record);
             $DB->update_record('forum_posts', $record);
+            $recordscount++;
         }
 
-        $recordscount = count($recordset);
         $recordset->close();
 
         return ($recordscount == $chunksize);