MDL-72720 message: Implement enable_plugin() method

moodle · Oct 15, 2021 · a7570bf · a7570bf
1 parent 105be1e
commit a7570bf
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 4 deletions.
diff --git a/admin/message.php b/admin/message.php
@@ -119,10 +119,8 @@
     // Save processors enabled/disabled status.
     foreach ($allprocessors as $processor) {
         $enabled = isset($form->{$processor->name});
-        if ($enabled != $processor->enabled) {
-            add_to_config_log($processor->name, $processor->enabled, $enabled, 'core');
-        }
-        \core_message\api::update_processor_status($processor, $enabled);
+        $class = \core_plugin_manager::resolve_plugininfo_class('message');
+        $class::enable_plugin($processor->name, $enabled);
     }
 
     foreach ($newpreferences as $name => $value) {

diff --git a/lib/classes/plugininfo/message.php b/lib/classes/plugininfo/message.php
@@ -40,6 +40,30 @@ public static function get_enabled_plugins() {
         return $DB->get_records_menu('message_processors', array('enabled'=>1), 'name ASC', 'name, name AS val');
     }
 
+    public static function enable_plugin(string $pluginname, int $enabled): bool {
+        global $DB;
+
+        if (!$plugin = $DB->get_record('message_processors', ['name' => $pluginname])) {
+            throw new \moodle_exception('invalidplugin', 'message', '', $pluginname);
+        }
+
+        $haschanged = false;
+
+        // Only set visibility if it's different from the current value.
+        if ($plugin->enabled != $enabled) {
+            $haschanged = true;
+            $processor = \core_message\api::get_processed_processor_object($plugin);
+
+            // Include this information into config changes table.
+            add_to_config_log($processor->name, $processor->enabled, $enabled, 'core');
+
+            // Save processor enabled/disabled status.
+            \core_message\api::update_processor_status($processor, $enabled);
+        }
+
+        return $haschanged;
+    }
+
     public function get_settings_section_name() {
         return 'messagesetting' . $this->name;
     }