Skip to content

Commit

Permalink
rating MDL-26461 fixed an off by 1 bug that made the safeguard agains…
Browse files Browse the repository at this point in the history
…t too high ratings not work
  • Loading branch information
andyjdavis committed Feb 21, 2011
1 parent d20b966 commit aafa4f3
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion rating/index.php
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,8 @@
echo "<th class=\"header\" scope=\"col\"><a href=\"index.php?$sortargs&amp;sort=time\">$strtime</a></th>";
echo "</tr>";

$maxrating = count($scalemenu);
//if the scale was changed after ratings were submitted some ratings may have a value above the current maximum
$maxrating = count($scalemenu) - 1;
foreach ($ratings as $rating) {
//Undo the aliasing of the user id column from user_picture::fields()
//we could clone the rating object or preserve the rating id if we needed it again
Expand Down

0 comments on commit aafa4f3

Please sign in to comment.