MDL-77918 gradereport_grader: zindex the dropdowns to overlap better

moodle · Apr 19, 2023 · b0aff92 · b0aff92
1 parent 0e08d0d
commit b0aff92
Show file tree

Hide file tree

Showing 6 changed files with 16 additions and 2 deletions.
diff --git a/grade/report/grader/amd/build/stickycolspan.min.js b/grade/report/grader/amd/build/stickycolspan.min.js
diff --git a/grade/report/grader/amd/build/stickycolspan.min.js.map b/grade/report/grader/amd/build/stickycolspan.min.js.map
diff --git a/grade/report/grader/amd/src/stickycolspan.js b/grade/report/grader/amd/src/stickycolspan.js
@@ -28,6 +28,7 @@ const SELECTORS = {
     BEHAT: 'body.behat-site',
     AVERAGEROW: 'tr.lastrow',
     TABLEHEADING: 'tr.heading',
+    GRADERDROPDOWN: 'tr th.category .dropdown-menu',
 };
 
 /**
@@ -45,6 +46,12 @@ export const init = () => {
         i++;
     });
 
+    const categoryDropdowns = grader.querySelectorAll(SELECTORS.GRADERDROPDOWN);
+    categoryDropdowns.forEach(dropdown => {
+        // Ensure we take all the displayed users + any & all categories and add a bit extra for safe measure.
+        dropdown.style.zIndex = (tableHeaders.length + categoryDropdowns.length) + 1;
+    });
+
     const tableHeader = grader.querySelector(SELECTORS.TABLEHEADING);
     tableHeader.style.zIndex = tableHeaders.length + 1;
 

diff --git a/theme/boost/scss/moodle/grade.scss b/theme/boost/scss/moodle/grade.scss
@@ -498,6 +498,7 @@
  */
 .path-grade-report-grader {
     .gradeparent {
+        z-index: 5;
         tr .cell,
         .floater .cell {
             background-color: $pagination-bg;

diff --git a/theme/boost/style/moodle.css b/theme/boost/style/moodle.css
@@ -34956,6 +34956,9 @@ p.arrow_button {
 /**
  * Grader report.
  */
+.path-grade-report-grader .gradeparent {
+  z-index: 5;
+}
 .path-grade-report-grader .gradeparent tr .cell,
 .path-grade-report-grader .gradeparent .floater .cell {
   background-color: #fff;

diff --git a/theme/classic/style/moodle.css b/theme/classic/style/moodle.css
@@ -34956,6 +34956,9 @@ p.arrow_button {
 /**
  * Grader report.
  */
+.path-grade-report-grader .gradeparent {
+  z-index: 5;
+}
 .path-grade-report-grader .gradeparent tr .cell,
 .path-grade-report-grader .gradeparent .floater .cell {
   background-color: #fff;