Merge branch 'MDL-73624-400' of https://github.com/meirzamoodle/moodle …

…into MOODLE_400_STABLE
moodle · Nov 7, 2022 · b2b7a09 · b2b7a09
2 parents 8858280 + 10ac386
commit b2b7a09
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/lib/spout/readme_moodle.txt b/lib/spout/readme_moodle.txt
@@ -4,6 +4,15 @@ Description of Spout library import
 * Only include the src/Spout directory.
 * Update lib/thirdpartylibs.xml with the latest version.
 
+2022/10/27
+----------
+Changes:
+Box/Spout has been archived and is no longer maintained,
+MDL-73624 needs to fix with a couple of minor changes to
+Writer/WriterAbstract.php. The changes replace rawurldecode() with
+rawurlencode() in lines 143 and 144.
+by Meirza <meirza.arson@moodle.com>
+
 2021/09/01
 ----------
 Update to v3.3.0 (MDL-71707)

diff --git a/lib/spout/src/Spout/Writer/WriterAbstract.php b/lib/spout/src/Spout/Writer/WriterAbstract.php
@@ -140,8 +140,8 @@ public function openToBrowser($outputFileName)
         $this->globalFunctionsHelper->header('Content-Type: ' . static::$headerContentType);
         $this->globalFunctionsHelper->header(
             'Content-Disposition: attachment; ' .
-            'filename="' . rawurldecode($this->outputFilePath) . '"; ' .
-            'filename*=UTF-8\'\'' . rawurldecode($this->outputFilePath)
+            'filename="' . rawurlencode($this->outputFilePath) . '"; ' .
+            'filename*=UTF-8\'\'' . rawurlencode($this->outputFilePath)
         );
 
         /*