MDL-65799 core: Final deprecation of 3.8 functions

moodle · Nov 10, 2021 · b98d5c1 · b98d5c1
1 parent e871e80
commit b98d5c1
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 12 deletions.
diff --git a/lib/deprecatedlib.php b/lib/deprecatedlib.php
@@ -2757,20 +2757,12 @@ function get_courses_page() {
 }
 
 /**
- * Returns the models that generated insights in the provided context.
- *
- * @deprecated since Moodle 3.8 MDL-66091 - please do not use this function any more.
- * @todo MDL-65799 This will be deleted in Moodle 4.0
- * @see \core_analytics\manager::cached_models_with_insights
- * @param  \context $context
- * @return int[]
+ * @deprecated since Moodle 3.8
  */
 function report_insights_context_insights(\context $context) {
-
-    debugging('report_insights_context_insights is deprecated. Please use ' .
-        '\core_analytics\manager::cached_models_with_insights instead', DEBUG_DEVELOPER);
-
-    return \core_analytics\manager::cached_models_with_insights($context);
+    throw new coding_exception(
+        'Function report_insights_context_insights() has been removed. \core_analytics\manager::cached_models_with_insights instead'
+    );
 }
 
 /**

diff --git a/lib/upgrade.txt b/lib/upgrade.txt
@@ -115,6 +115,7 @@ completely removed from Moodle core too.
 * Final deprecation: The following functions along with associated tests have been removed:
   - core_grades_external::get_grades
   - core_grades_external::get_grade_item
+  - report_insights_context_insights
 * \core\session\manager::init_empty_session() has a new optional parameter $newsid to indicate whether this is a new user session
 * New html_table attribute "$responsive" which defaults to true. When set to true, tables created via html_writer::table() will be enclosed
   in a .table-responsive div container which will allow the table to be scrolled horizontally with ease, especially when the table is rendered in smaller viewports.