Skip to content

Commit

Permalink
MDL-73339 lp: Add block only if main feature is enabled
Browse files Browse the repository at this point in the history
The Learning plans block should be added only if the competencies
advanced feature is enabled.
  • Loading branch information
sarjona committed Dec 30, 2021
1 parent c435627 commit bafe63d
Show file tree
Hide file tree
Showing 2 changed files with 72 additions and 0 deletions.
9 changes: 9 additions & 0 deletions blocks/lp/block_lp.php
Expand Up @@ -81,4 +81,13 @@ public function get_content() {
return $this->content;
}

/**
* This block shouldn't be added to a page if the competencies advanced feature is disabled.
*
* @param moodle_page $page
* @return bool
*/
public function can_block_be_added(moodle_page $page): bool {
return get_config('core_competency', 'enabled');
}
}
63 changes: 63 additions & 0 deletions blocks/lp/tests/lp_test.php
@@ -0,0 +1,63 @@
<?php
// This file is part of Moodle - http://moodle.org/
//
// Moodle is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
// Moodle is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
//
// You should have received a copy of the GNU General Public License
// along with Moodle. If not, see <http://www.gnu.org/licenses/>.

namespace block_lp\tests;

use advanced_testcase;
use block_lp;
use context_course;

/**
* PHPUnit block_lp tests
*
* @package block_lp
* @category test
* @copyright 2021 Sara Arjona (sara@moodle.com)
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
* @coversDefaultClass \block_lp
*/
class lp_test extends advanced_testcase {
public static function setUpBeforeClass(): void {
require_once(__DIR__ . '/../../moodleblock.class.php');
require_once(__DIR__ . '/../block_lp.php');
}

/**
* Test the behaviour of can_block_be_added() method.
*
* @covers ::can_block_be_added
*/
public function test_can_block_be_added(): void {
$this->resetAfterTest();
$this->setAdminUser();

// Create a course and prepare the page where the block will be added.
$course = $this->getDataGenerator()->create_course();
$page = new \moodle_page();
$page->set_context(context_course::instance($course->id));
$page->set_pagelayout('course');

$block = new block_lp();

// If blogs advanced feature is enabled, the method should return true.
set_config('enabled', true, 'core_competency');
$this->assertTrue($block->can_block_be_added($page));

// However, if the blogs advanced feature is disabled, the method should return false.
set_config('enabled', false, 'core_competency');
$this->assertFalse($block->can_block_be_added($page));
}
}

0 comments on commit bafe63d

Please sign in to comment.