Skip to content

Commit

Permalink
MDL-71639 qbank_exporttoxml: Add Export to xml plugin to core
Browse files Browse the repository at this point in the history
This implementation will introduce a qbank plugin "exporttoxml"
which will implement the export to xml action in the question
bank view by replacing the core class. Having this plugin will
give users the flexibility of enabling or disabling this action.
  • Loading branch information
safatshahin committed Sep 2, 2021
1 parent 443a980 commit c1797c6
Show file tree
Hide file tree
Showing 14 changed files with 443 additions and 47 deletions.
1 change: 1 addition & 0 deletions lib/classes/plugin_manager.php
Expand Up @@ -1941,6 +1941,7 @@ public static function standard_plugins_list($type) {
'qbank' => [
'deletequestion',
'editquestion',
'exporttoxml',
'exportquestions',
'importquestions',
'viewcreator',
Expand Down
22 changes: 6 additions & 16 deletions lib/questionlib.php
Expand Up @@ -2357,24 +2357,14 @@ function question_make_export_url($contextid, $categoryid, $format, $withcategor
* question_bank::load_question_data() or question_bank::make_question().
* (Only ->id and ->contextid are used.)
* @return moodle_url the requested URL.
* @deprecated since Moodle 4.0
* @see \qbank_exporttoxml\helper::question_get_export_single_question_url()
* @todo Final deprecation on Moodle 4.4 MDL-72438
*/
function question_get_export_single_question_url($question) {
$params = ['id' => $question->id, 'sesskey' => sesskey()];
$context = context::instance_by_id($question->contextid);
switch ($context->contextlevel) {
case CONTEXT_MODULE:
$params['cmid'] = $context->instanceid;
break;

case CONTEXT_COURSE:
$params['courseid'] = $context->instanceid;
break;

default:
$params['courseid'] = SITEID;
}

return new moodle_url('/question/exportone.php', $params);
debugging('Function question_get_export_single_question_url() has been deprecated and moved to qbank_exporttoxml plugin,
please use qbank_exporttoxml\helper::question_get_export_single_question_url() instead.', DEBUG_DEVELOPER);
qbank_exporttoxml\helper::question_get_export_single_question_url($question);
}

/**
Expand Down
30 changes: 0 additions & 30 deletions lib/tests/questionlib_test.php
Expand Up @@ -2068,36 +2068,6 @@ public function test_question_categorylist_parents() {
$this->assertCount(2, $parentcategories);
}

public function test_question_get_export_single_question_url() {
$generator = $this->getDataGenerator();

// Create a course and an activity.
$course = $generator->create_course();
$quiz = $generator->create_module('quiz', ['course' => $course->id]);

// Create a question in each place.
$questiongenerator = $generator->get_plugin_generator('core_question');
$courseqcat = $questiongenerator->create_question_category(['contextid' => context_course::instance($course->id)->id]);
$courseq = $questiongenerator->create_question('truefalse', null, ['category' => $courseqcat->id]);
$quizqcat = $questiongenerator->create_question_category(['contextid' => context_module::instance($quiz->cmid)->id]);
$quizq = $questiongenerator->create_question('truefalse', null, ['category' => $quizqcat->id]);
$systemqcat = $questiongenerator->create_question_category();
$systemq = $questiongenerator->create_question('truefalse', null, ['category' => $systemqcat->id]);

// Verify some URLs.
$this->assertEquals(new moodle_url('/question/exportone.php',
['id' => $courseq->id, 'courseid' => $course->id, 'sesskey' => sesskey()]),
question_get_export_single_question_url(question_bank::load_question_data($courseq->id)));

$this->assertEquals(new moodle_url('/question/exportone.php',
['id' => $quizq->id, 'cmid' => $quiz->cmid, 'sesskey' => sesskey()]),
question_get_export_single_question_url(question_bank::load_question($quizq->id)));

$this->assertEquals(new moodle_url('/question/exportone.php',
['id' => $systemq->id, 'courseid' => SITEID, 'sesskey' => sesskey()]),
question_get_export_single_question_url(question_bank::load_question($systemq->id)));
}

/**
* Get test cases for test_core_question_find_next_unused_idnumber.
*
Expand Down
59 changes: 59 additions & 0 deletions question/bank/exporttoxml/classes/export_xml_action_column.php
@@ -0,0 +1,59 @@
<?php
// This file is part of Moodle - http://moodle.org/
//
// Moodle is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
// Moodle is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
//
// You should have received a copy of the GNU General Public License
// along with Moodle. If not, see <http://www.gnu.org/licenses/>.

namespace qbank_exporttoxml;

use core_question\local\bank\menu_action_column_base;

/**
* Question bank column export the question in Moodle XML format.
*
* @package qbank_exporttoxml
* @copyright 2019 The Open University
* @author 2021 Safat Shahin <safatshahin@catalyst-au.net>
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/
class export_xml_action_column extends menu_action_column_base {

/** @var string avoids repeated calls to get_string('duplicate'). */
protected $strexportasxml;

public function init(): void {
parent::init();
$this->strexportasxml = get_string('exportasxml', 'question');
}

public function get_name(): string {
return 'exportasxmlaction';
}

protected function get_url_icon_and_label(\stdClass $question): array {
if (!\question_bank::is_qtype_installed($question->qtype)) {
// It sometimes happens that people end up with junk questions
// in their question bank of a type that is no longer installed.
// We cannot do most actions on them, because that leads to errors.
return [null, null, null];
}

if (!question_has_capability_on($question, 'view')) {
return [null, null, null];
}

return [helper::question_get_export_single_question_url($question),
't/download', $this->strexportasxml];
}

}
56 changes: 56 additions & 0 deletions question/bank/exporttoxml/classes/helper.php
@@ -0,0 +1,56 @@
<?php
// This file is part of Moodle - http://moodle.org/
//
// Moodle is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
// Moodle is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
//
// You should have received a copy of the GNU General Public License
// along with Moodle. If not, see <http://www.gnu.org/licenses/>.

namespace qbank_exporttoxml;

/**
* Class helper for export plugin.
*
* @package qbank_exporttoxml
* @copyright 2021 Catalyst IT Australia Pty Ltd
* @author Safat Shahin <safatshahin@catalyst-au.net>
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/
class helper {

/**
* Get the URL to export a single question (exportone.php).
*
* @param \stdClass|\question_definition $question the question definition as obtained from
* question_bank::load_question_data() or question_bank::make_question().
* (Only ->id and ->contextid are used.)
* @return \moodle_url the requested URL.
*/
public static function question_get_export_single_question_url($question): \moodle_url {
$params = ['id' => $question->id, 'sesskey' => sesskey()];
$context = \context::instance_by_id($question->contextid);
switch ($context->contextlevel) {
case CONTEXT_MODULE:
$params['cmid'] = $context->instanceid;
break;

case CONTEXT_COURSE:
$params['courseid'] = $context->instanceid;
break;

default:
$params['courseid'] = SITEID;
}

return new \moodle_url('/question/bank/exporttoxml/exportone.php', $params);
}

}
37 changes: 37 additions & 0 deletions question/bank/exporttoxml/classes/plugin_feature.php
@@ -0,0 +1,37 @@
<?php
// This file is part of Moodle - http://moodle.org/
//
// Moodle is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
// Moodle is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
//
// You should have received a copy of the GNU General Public License
// along with Moodle. If not, see <http://www.gnu.org/licenses/>.

namespace qbank_exporttoxml;

use core_question\local\bank\plugin_features_base;

/**
* Class plugin_feature is the entrypoint for the columns.
*
* @package qbank_exporttoxml
* @copyright 2021 Catalyst IT Australia Pty Ltd
* @author Safat Shahin <safatshahin@catalyst-au.net>
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/
class plugin_feature extends plugin_features_base {

public function get_question_columns($qbank): array {
return [
new export_xml_action_column($qbank)
];
}

}
32 changes: 32 additions & 0 deletions question/bank/exporttoxml/classes/privacy/provider.php
@@ -0,0 +1,32 @@
<?php
// This file is part of Moodle - http://moodle.org/
//
// Moodle is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
// Moodle is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
//
// You should have received a copy of the GNU General Public License
// along with Moodle. If not, see <http://www.gnu.org/licenses/>.

namespace qbank_exporttoxml\privacy;

/**
* Privacy Subsystem for qbank_exporttoxml implementing null_provider.
*
* @package qbank_exporttoxml
* @copyright 2021 Catalyst IT Australia Pty Ltd
* @author Safat Shahin <safatshahin@catalyst-au.net>
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/
class provider implements \core_privacy\local\metadata\null_provider {

public static function get_reason(): string {
return 'privacy:metadata';
}
}
82 changes: 82 additions & 0 deletions question/bank/exporttoxml/exportone.php
@@ -0,0 +1,82 @@
<?php
// This file is part of Moodle - http://moodle.org/
//
// Moodle is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
// Moodle is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
//
// You should have received a copy of the GNU General Public License
// along with Moodle. If not, see <http://www.gnu.org/licenses/>.

/**
* Script to download the export of a single question.
*
* @package qbank_exporttoxml
* @copyright 2015 the Open University
* @author Safat Shahin <safatshahin@catalyst-au.net>
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/

require_once(__DIR__ . '/../../../config.php');
require_once($CFG->libdir . '/questionlib.php');
require_once($CFG->dirroot . '/question/format/xml/format.php');

// Get the parameters from the URL.
$questionid = required_param('id', PARAM_INT);
$cmid = optional_param('cmid', 0, PARAM_INT);
$courseid = optional_param('courseid', 0, PARAM_INT);
$urlparams = ['id' => $questionid, 'sesskey' => sesskey()];

\core_question\local\bank\helper::require_plugin_enabled('qbank_exporttoxml');

if ($cmid) {
$cm = get_coursemodule_from_id(null, $cmid);
require_login($cm->course, false, $cm);
$thiscontext = context_module::instance($cmid);
$urlparams['cmid'] = $cmid;
} else if ($courseid) {
require_login($courseid, false);
$thiscontext = context_course::instance($courseid);
$urlparams['courseid'] = $courseid;
} else {
throw new moodle_exception('missingcourseorcmid', 'question');
}
require_sesskey();

// Load the necessary data.
$contexts = new question_edit_contexts($thiscontext);
$questiondata = question_bank::load_question_data($questionid);

// Check permissions.
question_require_capability_on($questiondata, 'view');

// Initialise $PAGE. Nothing is output, so this does not really matter. Just avoids notices.
$nexturl = new moodle_url('/question/type/stack/questiontestrun.php', $urlparams);
$PAGE->set_url('/question/bank/exporttoxml/exportone.php', $urlparams);
$PAGE->set_heading($COURSE->fullname);
$PAGE->set_pagelayout('admin');

// Set up the export format.
$qformat = new qformat_xml();
$filename = question_default_export_filename($COURSE, $questiondata) .
$qformat->export_file_extension();
$qformat->setContexts($contexts->having_one_edit_tab_cap('export'));
$qformat->setCourse($COURSE);
$qformat->setQuestions([$questiondata]);
$qformat->setCattofile(false);
$qformat->setContexttofile(false);

// Do the export.
if (!$qformat->exportpreprocess()) {
send_file_not_found();
}
if (!$content = $qformat->exportprocess(true)) {
send_file_not_found();
}
send_file($content, $filename, 0, 0, true, true, $qformat->mime_type());
27 changes: 27 additions & 0 deletions question/bank/exporttoxml/lang/en/qbank_exporttoxml.php
@@ -0,0 +1,27 @@
<?php
// This file is part of Moodle - http://moodle.org/
//
// Moodle is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
// Moodle is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
//
// You should have received a copy of the GNU General Public License
// along with Moodle. If not, see <http://www.gnu.org/licenses/>.

/**
* Strings for component qbank_exporttoxml, language 'en'
*
* @package qbank_exporttoxml
* @copyright 2021 Catalyst IT Australia Pty Ltd
* @author Safat Shahin <safatshahin@catalyst-au.net>
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/

$string['pluginname'] = 'Export to XML';
$string['privacy:metadata'] = 'Export to xml question bank plugin does not store any user data.';

0 comments on commit c1797c6

Please sign in to comment.