Merge branch 'MDL-80706' of https://github.com/marinaglancy/moodle

moodle · Feb 1, 2024 · c35f04c · c35f04c
2 parents 3606eba + 610f4a5
commit c35f04c
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/customfield/classes/handler.php b/customfield/classes/handler.php
@@ -652,7 +652,7 @@ public function instance_form_definition(\MoodleQuickForm $mform, int $instancei
             }
             $data->instance_form_definition($mform);
             $field = $data->get_field()->to_record();
-            if (strlen($field->description)) {
+            if (strlen((string)$field->description)) {
                 // Add field description.
                 $context = $this->get_configuration_context();
                 $value = file_rewrite_pluginfile_urls($field->description, 'pluginfile.php',

diff --git a/customfield/field/text/tests/plugin_test.php b/customfield/field/text/tests/plugin_test.php
@@ -47,7 +47,7 @@ public function setUp(): void {
 
         $this->cfields[1] = $this->get_generator()->create_field(
             ['categoryid' => $this->cfcat->get('id'), 'shortname' => 'myfield1', 'type' => 'text',
-                'configdata' => ['maxlength' => 30, 'displaysize' => 50]]);
+                'configdata' => ['maxlength' => 30, 'displaysize' => 50], 'description' => null]);
         $this->cfields[2] = $this->get_generator()->create_field(
             ['categoryid' => $this->cfcat->get('id'), 'shortname' => 'myfield2', 'type' => 'text',
                 'configdata' => ['required' => 1, 'maxlength' => 30, 'displaysize' => 50]]);

diff --git a/customfield/tests/generator/lib.php b/customfield/tests/generator/lib.php
@@ -97,7 +97,7 @@ public function create_field($record) : field_controller {
         if (!isset($record->shortname)) {
             $record->shortname = "fld$i";
         }
-        if (!isset($record->description)) {
+        if (!property_exists($record, 'description')) {
             $record->description = "Field $i description";
         }
         if (!isset($record->descriptionformat)) {