Skip to content

Commit

Permalink
Revert "MDL-38678 SCORM: Runtime Environment (RTE) checks not require…
Browse files Browse the repository at this point in the history
…d in case of SCO Assets"

This reverts commit fe10476.
  • Loading branch information
danpoltawski committed Apr 5, 2013
1 parent a8fdb36 commit c39896e
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 19 deletions.
8 changes: 0 additions & 8 deletions mod/scorm/datamodels/debug.js.php
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -737,14 +737,6 @@ function LogAPICall(func, nam, val, rc) {
} }
s += ' => ' + String(rc); s += ' => ' + String(rc);
AppendToLog(s, rc); AppendToLog(s, rc);
<?php
if (scorm_debugging($scorm) && ($sco->scormtype == 'asset')) {
?>
hint = 'Item <?php echo $sco->identifier; ?> has been defined as an Asset: it should never call the SCORM API';
AppendToLog(hint, 101);
<?php
}
?>
} }




Expand Down
14 changes: 3 additions & 11 deletions mod/scorm/loadSCO.php
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -161,19 +161,11 @@


add_to_log($course->id, 'scorm', 'launch', 'view.php?id='.$cm->id, $result, $cm->id); add_to_log($course->id, 'scorm', 'launch', 'view.php?id='.$cm->id, $result, $cm->id);


header('Content-Type: text/html; charset=UTF-8'); // which API are we looking for

if ($sco->scormtype == 'asset') {
// HTTP 302 Found => Moved Temporarily.
header('Location: ' . $result);
// Provide a short feedback in case of slow network connection.
echo '<html><body><p>' . get_string('activitypleasewait', 'scorm'). '</p></body></html>';
exit;
}

// We expect a SCO: select which API are we looking for.
$LMS_api = (scorm_version_check($scorm->version, SCORM_12) || empty($scorm->version)) ? 'API' : 'API_1484_11'; $LMS_api = (scorm_version_check($scorm->version, SCORM_12) || empty($scorm->version)) ? 'API' : 'API_1484_11';


header('Content-Type: text/html; charset=UTF-8');

?> ?>
<html> <html>
<head> <head>
Expand Down

0 comments on commit c39896e

Please sign in to comment.