MDL-60547 message_popup: adding preventDefault at notification popover

moodle · Feb 22, 2018 · c4f22db · c4f22db
1 parent 2e8f163
commit c4f22db
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/message/output/popup/amd/build/notification_popover_controller.min.js b/message/output/popup/amd/build/notification_popover_controller.min.js
diff --git a/message/output/popup/amd/src/notification_popover_controller.js b/message/output/popup/amd/src/notification_popover_controller.js
@@ -357,9 +357,10 @@ define(['jquery', 'core/ajax', 'core/templates', 'core/str', 'core/url',
         ]);
 
         // Mark all notifications read if the user activates the mark all as read button.
-        this.root.on(CustomEvents.events.activate, SELECTORS.MARK_ALL_READ_BUTTON, function(e) {
+        this.root.on(CustomEvents.events.activate, SELECTORS.MARK_ALL_READ_BUTTON, function(e, data) {
             this.markAllAsRead();
             e.stopPropagation();
+            data.originalEvent.preventDefault();
         }.bind(this));
 
         // Mark individual notification read if the user activates it.